chore: Map the parameters for reasoning models #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
[q] Should reasoning_effort also be implemented here? It looks like a whole new feature. |
davidkna-sap
reviewed
Dec 2, 2025
Member
davidkna-sap
left a comment
davidkna-sap
left a comment
There was a problem hiding this comment.
I was actually thinking of using a unit test here, but this should do the job too - I only have two small nitpicks.
Co-authored-by: David Knaack <[email protected]>
Co-authored-by: David Knaack <[email protected]>
Member
davidkna-sap
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes SAP/ai-sdk-js-backlog#415.
What this PR does and why it is needed