Skip to content

Commit a231e6f

Browse files
committed
Remove LUFactorization method for AbstractSciMLOperator
The LUFactorization method for AbstractSciMLOperator was causing issues with the default algorithm selection. This removes it while keeping support for KLU and UMFPACK factorizations with operators that have concretization support. Fixes #848
1 parent 932c52e commit a231e6f

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

ext/LinearSolveSparseArraysExt.jl

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -300,18 +300,6 @@ function LinearSolve.init_cacheval(
300300
end
301301
end
302302

303-
function LinearSolve.init_cacheval(
304-
alg::LUFactorization, A::AbstractSciMLOperator, b, u, Pl, Pr,
305-
maxiters::Int, abstol, reltol,
306-
verbose::Union{LinearVerbosity, Bool}, assumptions::OperatorAssumptions)
307-
if has_concretization(A)
308-
return LinearSolve.init_cacheval(alg, convert(AbstractMatrix, A), b, u, Pl, Pr,
309-
maxiters, abstol, reltol, verbose, assumptions)
310-
else
311-
nothing
312-
end
313-
end
314-
315303
function LinearSolve.init_cacheval(
316304
alg::CHOLMODFactorization, A::AbstractSciMLOperator, b, u, Pl, Pr,
317305
maxiters::Int, abstol, reltol,

test/basictests.jl

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -584,11 +584,6 @@ end
584584
sol_operator = solve(prob_operator, UMFPACKFactorization())
585585
@test sol_matrix.u sol_operator.u
586586

587-
# Test LU with operator
588-
sol_matrix = solve(prob_matrix, LUFactorization())
589-
sol_operator = solve(prob_operator, LUFactorization())
590-
@test sol_matrix.u sol_operator.u
591-
592587
# Test WOperator with sparse Jacobian
593588
n_w = 8
594589
M = sparse(I(n_w) * 1.0)
@@ -612,11 +607,6 @@ end
612607
sol_woperator = solve(prob_woperator, UMFPACKFactorization())
613608
sol_wmatrix = solve(prob_wmatrix, UMFPACKFactorization())
614609
@test sol_woperator.u sol_wmatrix.u
615-
616-
# Test LU with WOperator
617-
sol_woperator = solve(prob_woperator, LUFactorization())
618-
sol_wmatrix = solve(prob_wmatrix, LUFactorization())
619-
@test sol_woperator.u sol_wmatrix.u
620610
end
621611

622612
@testset "Solve Function" begin

0 commit comments

Comments
 (0)