Removing extra string compare

Removing extra promise then comparison
Fixing search test

Author: aaronbhansen

addon/mixins/base.js

@@ -134,9 +134,7 @@ Semantic.BaseMixin = Ember.Mixin.create({
 
   areAttrValuesEqual(attrName, attrValue, moduleValue) {
     return attrValue === moduleValue ||
-           this._stringCompare(attrValue) === moduleValue ||
-           attrValue === this._stringCompare(moduleValue) ||
-           this._stringCompare(attrValue) === this._stringCompare(moduleValue) ||
+           this._stringCompareIfPossible(attrValue) === this._stringCompareIfPossible(moduleValue) ||
            Ember.isEqual(attrValue, moduleValue);
   },
 
@@ -146,6 +144,7 @@ Semantic.BaseMixin = Ember.Mixin.create({
     if (module) {
       return module.apply(this.getSemanticScope(), arguments);
     }
+    Ember.Logger.warn("The execute method was called, but the Semantic-UI module didn't exist.");
   },
 
   actions: {
@@ -230,17 +229,20 @@ Semantic.BaseMixin = Ember.Mixin.create({
     };
   },
 
-  _stringCompare(value) {
+  _stringCompareIfPossible(value) {
+    // If its undefined or null, compare on null
     if (value == null) {
       return null;
     }
+    // We should only compare string values on primitive types
     switch (typeof value) {
       case "string":
         return value;
       case "boolean":
       case "number":
         return value.toString();
       default:
+        // Don't convert to string, otherwise it would be "[Object]"
         return value;
     }
   },

addon/utils/promise-tools.js

@@ -1,15 +1,7 @@
 import Ember from 'ember';
 
 const isPromise = function(maybePromise) {
-  if (Ember.PromiseProxyMixin.detect(maybePromise)) {
-    return true;
-  }
-
-  if (maybePromise instanceof Ember.RSVP.Promise) {
-    return true;
-  }
-
-  if (maybePromise != null && typeof maybePromise.then === 'function') {
+ if (maybePromise != null && typeof maybePromise.then === 'function') {
     return true;
   }
   return false;

tests/integration/components/ui-search-test.js

@@ -9,7 +9,7 @@ test('it renders', function(assert) {
   assert.expect(1);
 
   this.render(hbs`
-    {{#ui-search url="/search"}}
+    {{#ui-search apiSettings=(hash url="/search")}}
       <input class="prompt" type="text" placeholder="Common passwords...">
       <div class="results"></div>
     {{/ui-search}}