Fix ignoring arguments passed to save_model. #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, defaults were passed to _save_model, rather than the correct arguments the user supplied to save_model.
Codecov Report
@@ Coverage Diff @@
## devel #938 +/- ##
==========================================
- Coverage 54.59% 54.56% -0.03%
==========================================
Files 211 210 -1
Lines 21564 21527 -37
Branches 2891 2888 -3
==========================================
- Hits 11772 11747 -25
+ Misses 9240 9228 -12
Partials 552 552 |
Contributor
|
This looks good - to merge, we need a test that covers this code. That'll keep us from making the same mistake in the future. Please let me know if you need any help writing the test. I don't think it will be too onerous :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, defaults were passed to _save_model, rather than the
correct arguments the user supplied to save_model.