Fix(Sample): Archiving failing due to duplicate build outputs (#368)

* fix(sample): archiving unsuccessful

* feat: cleanup unnecessary workarounds for archiving ios

Author: kieran-osgood-shopify

sample/ios/Podfile

@@ -28,6 +28,9 @@ target 'ReactNative' do
     :new_arch_enabled => true
   )
 
+  # Pod dependency should be inside the target block
+  pod "RNShopifyCheckoutSheetKit", :path => "../../modules/@shopify/checkout-sheet-kit"
+
   target 'ReactNativeTests' do
     inherit! :complete
   end
@@ -41,19 +44,5 @@ target 'ReactNative' do
       :mac_catalyst_enabled => false,
       :ccache_enabled => true
     )
-
-    # WORKAROUND
-    # This fixes issues with the 'React-Core-AccessibilityResources' dependency when archiving the sample app in XCode:
-    installer.pods_project.targets.each do |target|
-      if target.name == "React-Core-AccessibilityResources"
-        target.remove_from_project
-      end
-
-      if target.name == "React-Core-RCTI18nStrings"
-        target.remove_from_project
-      end
-    end
   end
 end
-
-pod "RNShopifyCheckoutSheetKit", :path => "../../modules/@shopify/checkout-sheet-kit"

sample/ios/Podfile.lock

@@ -2888,6 +2888,6 @@ SPEC CHECKSUMS:
   SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
   Yoga: a742cc68e8366fcfc681808162492bc0aa7a9498
 
-PODFILE CHECKSUM: 42a4ad42b0177ca0f927363d8f2b6059c6dd77c7
+PODFILE CHECKSUM: f2daae5c793dd9545ae6e55c038d9108806ba98c
 
 COCOAPODS: 1.15.2

sample/ios/ReactNative/ReactNative.entitlements

@@ -5,9 +5,11 @@
 	<key>com.apple.developer.associated-domains</key>
 	<array>
 		<string>webcredentials:myshopify.com</string>
-    <string>applinks:myshopify.com</string>
+		<string>applinks:myshopify.com</string>
 	</array>
 	<key>com.apple.developer.in-app-payments</key>
-	<true/>
+	<array>
+		<string>merchant.com.shopify.example.CheckoutKitReactNative.ApplePay</string>
+	</array>
 </dict>
 </plist>