Fix iOS Archiving / Dynamic App Display Name from .env #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiftio
reviewed
Nov 4, 2025
kieran-osgood-shopify
force-pushed
the
prototype-development/archiving
branch
from
05d9b3e to
42a95b8
Compare
kieran-osgood-shopify
changed the title
kiftio
reviewed
Nov 4, 2025
kiftio
reviewed
Nov 7, 2025
| "turbo": "turbo", | ||
| "test": "jest" | ||
| "test": "jest", | ||
| "env-to-xcconfig": "./scripts/env_to_xcconfig" |
Contributor
There was a problem hiding this comment.
I think we need a .sh suffix here
I get command not found: ./scripts/env_to_xcconfig without it
Contributor
Author
There was a problem hiding this comment.
dang it - im going to rename the script
I forgot to retest this part as teccccchnically the xcode build will always run this, so i feel like its maybe superfluous to even have an imperative way to call it
kiftio
reviewed
Nov 7, 2025
kiftio
requested changes
Nov 7, 2025
Contributor
kiftio
left a comment
kiftio
left a comment
There was a problem hiding this comment.
Just need to fix up the suffix
kiftio
approved these changes
Nov 10, 2025
kieran-osgood-shopify
force-pushed
the
prototype-development/archiving
branch
from
aa1a443 to
b097053
Compare
kieran-osgood-shopify
merged commit 1868898
into
prototype/development
5 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
.envas aJSEnvironment.xcconfig- which the iOS app now uses to configure the CFBundleDisplayName (name of the app in app launcher on iOS)I've added pre-build commands which will ensure that the JSEnvironment is created before continuing with xcode compilation
Given a display_name like this:
iOS:
Android:
PR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.