Ruby LSP doesn't auto-update with addons in Gemfile

[janko]

I recently added ruby-lsp-rspec and ruby-lsp-factory_bot gems to my Gemfile, which added ruby-lsp to my Gemfile.lock as a transitive dependency. Unfortunately, that seems to stop ruby-lsp from auto-updating in its composed bundle, .ruby-lsp/Gemfile.lock still has the locked version from the project's Gemfile.lock.

This is probably not a bug, because I imagine it's harder for Ruby LSP to know whether you want the ruby-lsp version locked. I just found it really convenient that Ruby LSP doesn't need to be added to the Gemfile and that it auto-updates, so I don't want to lose that just because I installed addons.

My proposal is that Ruby LSP always tries to auto-update to latest version allowed by the project's Gemfile (in .ruby-lsp/Gemfile.lock). That way if users still want to lock ruby-lsp to a certain version and prevent auto-updates, they can lock it in the Gemfile. This seems like a reasonable requirement to me.

[vinistock]

Thanks for the report. This should be working actually. We only avoid the auto updates if you add the ruby-lsp as a direct dependency in the Gemfile.

If it's transitive, we still run the update, which should always be scoped only to the bundle composed under the .ruby-lsp directory.

What symptoms did you identify that the LSP was not updating anymore? Are any of the add-ons constraining the version of the ruby-lsp (which would prevent the update)?

[janko]

This is the relevant part of my Gemfile.lock:

ruby-lsp (0.26.3)
  language_server-protocol (~> 3.17.0)
  prism (>= 1.2, < 2.0)
  rbs (>= 3, < 5)
ruby-lsp-factory_bot (0.6.0)
  ruby-lsp (~> 0.26.0)
ruby-lsp-rspec (0.1.28)
  ruby-lsp (~> 0.26.0)

I tried deleting the .ruby-lsp/ directory, then restarted the language server (in Zed), which then re-created the .ruby-lsp/ directory, and I saw in .ruby-lsp/Gemfile.lock that ruby-lsp is also locked to 0.26.3 (and language server logs confirm this version), but 0.26.4 is the current latest version.

For completeness, this is the relevant part of my Gemfile (ruby-lsp isn't directly specified there):

group :development do
  gem 'ruby-lsp-factory_bot', require: false
  gem 'ruby-lsp-rspec', require: false
end

[janko]

I also verified that there is nothing blocking the update, running bundle update ruby-lsp successfully updates ruby-lsp to version 0.26.4.