v1beta2: Remove deprecated retryDelayMinutes field and fix conversion (kubernetes-sigs#7407)

- Remove retryDelayMinutes field from AdmissionCheckSpec in v1beta2
- Add conversion function for AdmissionCheckSpec from v1beta1 to v1beta2
- Update CRD, generated code, and documentation
- Update integration tests to reflect changes

Author: nerdeveloper

apis/kueue/v1beta1/admissioncheck_conversion.go

@@ -0,0 +1,30 @@
+/*
+Copyright The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1beta1
+
+import (
+	conversionapi "k8s.io/apimachinery/pkg/conversion"
+
+	"sigs.k8s.io/kueue/apis/kueue/v1beta2"
+)
+
+//lint:file-ignore ST1003 "generated Convert_* calls below use underscores"
+//revive:disable:var-naming
+
+func Convert_v1beta1_AdmissionCheckSpec_To_v1beta2_AdmissionCheckSpec(in *AdmissionCheckSpec, out *v1beta2.AdmissionCheckSpec, s conversionapi.Scope) error {
+	return autoConvert_v1beta1_AdmissionCheckSpec_To_v1beta2_AdmissionCheckSpec(in, out, s)
+}

apis/kueue/v1beta1/zz_generated.conversion.go

@@ -54,14 +54,6 @@ type AdmissionCheckSpec struct {
 	// +kubebuilder:validation:MinLength=1
 	ControllerName string `json:"controllerName"`
 
-	// retryDelayMinutes specifies how long to keep the workload suspended after
-	// a failed check (after it transitioned to False). When the delay period has passed, the check
-	// state goes to "Unknown". The default is 15 min.
-	// +optional
-	// +kubebuilder:default=15
-	// Deprecated: retryDelayMinutes has already been deprecated since v0.8 and will be removed in v1beta2.
-	RetryDelayMinutes *int64 `json:"retryDelayMinutes,omitempty"`
-
 	// parameters identifies a configuration with additional parameters for the
 	// check.
 	// +optional

apis/kueue/v1beta2/admissioncheck_types.go

@@ -236,15 +236,6 @@ spec:
                     - kind
                     - name
                   type: object
-                retryDelayMinutes:
-                  default: 15
-                  description: |-
-                    retryDelayMinutes specifies how long to keep the workload suspended after
-                    a failed check (after it transitioned to False). When the delay period has passed, the check
-                    state goes to "Unknown". The default is 15 min.
-                    Deprecated: retryDelayMinutes has already been deprecated since v0.8 and will be removed in v1beta2.
-                  format: int64
-                  type: integer
               required:
                 - controllerName
               type: object

apis/kueue/v1beta2/zz_generated.deepcopy.go

@@ -215,15 +215,6 @@ spec:
                 - kind
                 - name
                 type: object
-              retryDelayMinutes:
-                default: 15
-                description: |-
-                  retryDelayMinutes specifies how long to keep the workload suspended after
-                  a failed check (after it transitioned to False). When the delay period has passed, the check
-                  state goes to "Unknown". The default is 15 min.
-                  Deprecated: retryDelayMinutes has already been deprecated since v0.8 and will be removed in v1beta2.
-                format: int64
-                type: integer
             required:
             - controllerName
             type: object

charts/kueue/templates/crd/kueue.x-k8s.io_admissionchecks.yaml

@@ -498,16 +498,6 @@ The description is limited to a maximum of 2048 characters.</p>
 not necessarily a Kubernetes Pod or Deployment name. Cannot be empty.</p>
 </td>
 </tr>
-<tr><td><code>retryDelayMinutes</code><br/>
-<code>int64</code>
-</td>
-<td>
-   <p>retryDelayMinutes specifies how long to keep the workload suspended after
-a failed check (after it transitioned to False). When the delay period has passed, the check
-state goes to &quot;Unknown&quot;. The default is 15 min.
-Deprecated: retryDelayMinutes has already been deprecated since v0.8 and will be removed in v1beta2.</p>
-</td>
-</tr>
 <tr><td><code>parameters</code><br/>
 <a href="#kueue-x-k8s-io-v1beta2-AdmissionCheckParametersReference"><code>AdmissionCheckParametersReference</code></a>
 </td>

client-go/applyconfiguration/kueue/v1beta2/admissioncheckspec.go

@@ -24,7 +24,6 @@ import (
 	"github.com/onsi/gomega"
 	"github.com/onsi/gomega/types"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/utils/ptr"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
 
@@ -67,8 +66,7 @@ var _ = ginkgo.Describe("AdmissionCheck Webhook", ginkgo.Ordered, func() {
 						Name: "foo",
 					},
 					Spec: kueue.AdmissionCheckSpec{
-						ControllerName:    "ac-controller",
-						RetryDelayMinutes: ptr.To[int64](15),
+						ControllerName: "ac-controller",
 					},
 				},
 			),