add guards to some defines #337
Open
+144
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Shouldn't you also changed globals.h to change the order? |
Contributor
Author
|
The order should not mater, as it is a compiler define. So it is defined for every file. |
Contributor
Author
|
Changed order so defines.h can also change the parameters of debug.h |
unlogisch04
force-pushed
the
feat_defines
branch
from
205f7f4 to
93aaa29
Compare
Should address SlimeVR#334 Make defines.h more powerfull
unlogisch04
force-pushed
the
feat_defines
branch
from
1fd0fd7 to
b989ae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address #334 Make defines.h more powerfull