fix(objects): remove incorrect NO_SIDE_EFFECTS annotations from property definers

The defineGetter, defineLazyGetter, and defineLazyGetters functions mutate
objects by defining properties on them, so they have side effects. The
/*@__NO_SIDE_EFFECTS__*/ annotations caused esbuild to incorrectly tree-shake
these function calls when their return values weren't used, resulting in lazy
getters returning undefined instead of computed values.

Also removed double wrapping in defineLazyGetters where createLazyGetter was
being called unnecessarily before passing to defineLazyGetter (which already
calls createLazyGetter internally).

Fixes three failing tests:
- createConstantsObject > should create object with lazy getters
- defineLazyGetters > should define multiple lazy getters
- defineLazyGetters > should handle symbol keys in getters

Author: jdalton

.config/esbuild.config.mjs

@@ -40,12 +40,17 @@ function createAliasPlugin() {
       // Intercept imports for aliased packages
       for (const [packageName, aliasPath] of Object.entries(aliases)) {
         // Match both exact package name and subpath imports
-        build.onResolve({ filter: new RegExp(`^${packageName}(/|$)`) }, args => {
-          // Handle subpath imports like '@socketsecurity/lib/spinner'
-          const subpath = args.path.slice(packageName.length + 1)
-          const resolvedPath = subpath ? path.join(aliasPath, subpath) : aliasPath
-          return { path: resolvedPath, external: true }
-        })
+        build.onResolve(
+          { filter: new RegExp(`^${packageName}(/|$)`) },
+          args => {
+            // Handle subpath imports like '@socketsecurity/lib/spinner'
+            const subpath = args.path.slice(packageName.length + 1)
+            const resolvedPath = subpath
+              ? path.join(aliasPath, subpath)
+              : aliasPath
+            return { path: resolvedPath, external: true }
+          },
+        )
       }
     },
   }

src/objects.ts

@@ -272,7 +272,6 @@ export function createConstantsObject(
  * console.log(Object.keys(obj)) // [] (non-enumerable)
  * ```
  */
-/*@__NO_SIDE_EFFECTS__*/
 export function defineGetter<T>(
   object: object,
   propKey: PropertyKey,
@@ -309,7 +308,6 @@ export function defineGetter<T>(
  * console.log(obj.data) // Returns same data without logging
  * ```
  */
-/*@__NO_SIDE_EFFECTS__*/
 export function defineLazyGetter<T>(
   object: object,
   propKey: PropertyKey,
@@ -346,7 +344,6 @@ export function defineLazyGetter<T>(
  * console.log(stats.initialized) // Set(['user', 'config'])
  * ```
  */
-/*@__NO_SIDE_EFFECTS__*/
 export function defineLazyGetters(
   object: object,
   getterDefObj: GetterDefObj | undefined,
@@ -356,11 +353,7 @@ export function defineLazyGetters(
     const keys = ReflectOwnKeys(getterDefObj)
     for (let i = 0, { length } = keys; i < length; i += 1) {
       const key = keys[i] as PropertyKey
-      defineLazyGetter(
-        object,
-        key,
-        createLazyGetter(key, getterDefObj[key] as () => unknown, stats),
-      )
+      defineLazyGetter(object, key, getterDefObj[key] as () => unknown, stats)
     }
   }
   return object