7강 정연준 과제제출 #1
Open
7강 정연준 과제제출 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2025 13:33
meteorqz6
reviewed
May 26, 2025
Member
meteorqz6
left a comment
meteorqz6
left a comment
There was a problem hiding this comment.
과제하느라 고생하셨습니다! 코드 리뷰 반영해서 커밋 추가해주세요😊
| if (!weatherData) return []; | ||
| // 밑에 코드 채워주세요 | ||
| return []; | ||
| const time = weatherData.hourly.time; |
Member
There was a problem hiding this comment.
구조분해할당을 활용하면 가독성이 좋아질 것 같아요
const { time, temperature_2m, weather_code } = weatherData;
| if (!weatherData) return []; | ||
| // 밑에 코드 채워주세요 | ||
| return []; | ||
| const time = weatherData.daily.time; |
| }; | ||
| if (isLoading) { | ||
| return <div>채워주세요</div>; | ||
| return <div>현재날씨 로딩중...</div>; |
Member
There was a problem hiding this comment.
스켈레톤 컴포넌트 공부해서 적용해보면 좋을 것 같습니다
| {dailyData.map((data, idx) => ( | ||
| <DailyItem key={idx}> | ||
| <div> | ||
| {`${new Date(data.time).getMonth() + 1}월 ${new Date( |
Member
There was a problem hiding this comment.
날짜 및 요일과 같은 데이터 포맷 가공 로직은 관심사의 분리를 위해 weather.js의 formatDailyData에서 하는 것이 유지보수에 더 유리할 것 같아요
| {hourlyData.map((data, idx) => ( | ||
| <HourlyItem key={idx}> | ||
| <div> | ||
| {new Date(data.time).getHours().toString().padStart(2, "0")}시 |
Member
There was a problem hiding this comment.
날짜 및 요일과 같은 데이터 포맷 가공 로직은 관심사의 분리를 위해 weather.js의 formatHourlyData에서 하는 것이 유지보수에 더 유리할 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7강 과제제출입니다.