Skip to content

Commit df3cd27

Browse files
chenfengjinchoprahetarth
authored andcommitted
Force use C++17 globally to avoid compilation error (vllm-project#24823)
Signed-off-by: chenfengjin <[email protected]>
1 parent ed8150c commit df3cd27

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ cmake_minimum_required(VERSION 3.26)
1313
# cmake --install . --component _C
1414
project(vllm_extensions LANGUAGES CXX)
1515

16+
set(CMAKE_CXX_STANDARD 17)
17+
set(CMAKE_CXX_STANDARD_REQUIRED ON)
18+
19+
1620
# CUDA by default, can be overridden by using -DVLLM_TARGET_DEVICE=... (used by setup.py)
1721
set(VLLM_TARGET_DEVICE "cuda" CACHE STRING "Target device backend for vLLM")
1822
message(STATUS "Build type: ${CMAKE_BUILD_TYPE}")

cmake/utils.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,6 @@ function (define_gpu_extension_target GPU_MOD_NAME)
480480
${GPU_LANGUAGE}_ARCHITECTURES "${GPU_ARCHITECTURES}")
481481
endif()
482482

483-
set_property(TARGET ${GPU_MOD_NAME} PROPERTY CXX_STANDARD 17)
484483

485484
target_compile_options(${GPU_MOD_NAME} PRIVATE
486485
$<$<COMPILE_LANGUAGE:${GPU_LANGUAGE}>:${GPU_COMPILE_FLAGS}>)

0 commit comments

Comments
 (0)