Skip to content

Commit 55b2b1f

Browse files
committed
Document cyclic dependency.
To be fixed later, but this way it is already documented. (what needs to be done is probably break out the libraries in the BUILD file better). Signed-off-by: Henner Zeller <[email protected]>
1 parent a5c4dfa commit 55b2b1f

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

src/dbSta/BUILD

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,13 @@ package(
99
features = ["layering_check"],
1010
)
1111

12+
# TODO: there is a cyclic dependency between
13+
# some of these. dbSta depends on dbNetwork and
14+
# dbSdcNetwork, but these would need to include
15+
# dbSta.hh ...
16+
# So this probably needs to be broken into more
17+
# libraries.
18+
1219
cc_library(
1320
name = "dbSta",
1421
srcs = [

src/dbSta/src/dbNetwork.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,11 @@ Recommended conclusion: use map for concrete cells. They are invariant.
6868
#include "sta/Search.hh"
6969
#include "utl/Logger.h"
7070

71+
// Circular dependency! We need this header, but that
72+
// is provided by :dbSta which in turn depends
73+
// :dbNetwork ...
74+
// #include "db_sta/dbSta.hh"
75+
7176
namespace sta {
7277

7378
using utl::ORD;

src/dbSta/src/dbSdcNetwork.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@
1313
#include "sta/ParseBus.hh"
1414
#include "sta/PatternMatch.hh"
1515

16+
// Circular dependency! We would need this for
17+
// e.g. sta::Cell, but that requires to depend on :dbSta
18+
// which in turn depends on :dbStaNetwork ...
19+
// #include "db_sta/dbSta.hh"
20+
1621
namespace sta {
1722

1823
static std::string escapeDividers(const char* token, const Network* network);

0 commit comments

Comments
 (0)