Address division by zero and invalid duration

Addresses #93

Author: ThioJoe

Scripts/auth.py

@@ -22,8 +22,9 @@
 # Google Cloud Globals
 token_file_name = 'token.pickle'
 youtube_token_filename = 'yt_token.pickle'
-GOOGLE_TTS_API = None
-GOOGLE_TRANSLATE_API = None
+GOOGLE_TTS_API:Any = None
+GOOGLE_TRANSLATE_API:Any = None
+YOUTUBE_API:Any = None
 
 # deepl Globals
 DEEPL_API = None
@@ -125,7 +126,7 @@ def get_authenticated_service(youtubeAuth = False):
 def youtube_authentication():
   global YOUTUBE_API
   try:
-    YOUTUBE_API: Any = get_authenticated_service(youtubeAuth = True) # Create authentication object
+    YOUTUBE_API = get_authenticated_service(youtubeAuth = True) # Create authentication object
   except JSONDecodeError as jx:
     print(f" [!!!] Error: " + str(jx))
     print(f"\nDid you make the client_secrets.json file yourself by copying and pasting into it, instead of downloading it?")

Scripts/enums.py

@@ -92,4 +92,8 @@ class SubsDictKeys(str, Enum):
     speed_factor = "speed_factor"
 
     def __str__(self):
-        return self.value
+        return self.value
+    
+class VariousDefaults():
+    defaultSpeechRateGoal:float = 20
+

Scripts/load_configs.py

@@ -74,7 +74,7 @@ class Config:
     increase_max_chars_for_extreme_speeds: bool
     subtitle_gap_threshold_milliseconds: int
     prioritize_avoiding_fragmented_speech: bool
-    speech_rate_goal: Union[str, int] # 'Auto' or int
+    speech_rate_goal: Union[str, int, float] # 'Auto' or int
     debug_mode: bool
     youtube_autosync_languages: list[str]
 

Scripts/shared_imports.py

@@ -43,6 +43,7 @@
 LangDataKeys = enums.LangDataKeys
 LangDictKeys = enums.LangDictKeys
 SubsDictKeys = enums.SubsDictKeys
+VariousDefaults = enums.VariousDefaults
 
 # ---------------------------------------------------------------------------------------
 
@@ -72,7 +73,8 @@
     FormalityPreference,
     LangDataKeys,
     LangDictKeys,
-    SubsDictKeys
+    SubsDictKeys,
+    VariousDefaults
 ]
 
 # Export all objects

Scripts/translate.py

@@ -600,6 +600,7 @@ def set_translation_info(languageBatchDict):
 def combine_subtitles_advanced(inputDict, maxCharacters=200):
     # Set gap threshold, the maximum gap between subtitles to combine
     gapThreshold = config.subtitle_gap_threshold_milliseconds
+    charRateGoal:float
 
     if (config.speech_rate_goal == 'auto'):
         # Calculate average char rate goal by dividing the total number of characters by the total duration in seconds from the last subtitle timetsamp
@@ -608,10 +609,21 @@ def combine_subtitles_advanced(inputDict, maxCharacters=200):
         for key, value in inputDict.items():
             totalCharacters += len(value[SubsDictKeys.translated_text])
             totalDuration = int(value[SubsDictKeys.end_ms]) / 1000 # Just ends up staying as last subtitle timestamp
-        charRateGoal = totalCharacters / totalDuration
-        charRateGoal = round(charRateGoal, 2)
+        
+        # If the duration is zero there's a problem. Print a warning and try to continue
+        if totalDuration == 0:
+            print("ERROR: Total duration of subtitles is zero. Something may be wrong with your subtitles file or it's empty. The script will try to continue but don't expect good results.")
+            charRateGoal = VariousDefaults.defaultSpeechRateGoal
+        else:
+            charRateGoal = totalCharacters / totalDuration
+            charRateGoal = round(charRateGoal, 2)
     else:
-        charRateGoal = config.speech_rate_goal
+        # Check if it can be converted to a float, if not set to default
+        try:
+            charRateGoal = float(config.speech_rate_goal)
+        except ValueError:
+            print(f"WARNING: Invalid value for 'speech_rate_goal' in config. Setting to default value of {VariousDefaults.defaultSpeechRateGoal}")
+            charRateGoal = VariousDefaults.defaultSpeechRateGoal
 
     # Don't change this, it is not an option, it is for keeping track
     noMorePossibleCombines = False