More updates, more testing (redhat-cop#951)

* update typos tests

* move workflows temporarily

* more testing and tweaking

Author: sean-m-sullivan

roles/dispatch/defaults/main.yml

@@ -1,10 +1,10 @@
 ---
 gateway_configuration_dispatcher_roles:
   - role: gateway_authenticators
-    var: authenticators_list
+    var: gateway_authenticators
     tags: authenticators
   - role: gateway_authenticator_maps
-    var: authenticator_maps_list
+    var: gateway_authenticator_maps
     tags: authenticator_maps
   - role: gateway_settings
     var: gateway_settings
@@ -19,22 +19,22 @@ gateway_configuration_dispatcher_roles:
     var: aap_organizations
     tags: organizations
   - role: gateway_service_clusters
-    var: gateway_service_nodes
+    var: gateway_service_clusters
     tags: service_clusters
   - role: gateway_service_keys
-    var: service_keys_list
+    var: gateway_service_keys
     tags: service_keys
   - role: gateway_service_nodes
-    var: service_nodes_list
+    var: gateway_service_nodes
     tags: service_nodes
   - role: gateway_services
-    var: services_list
+    var: gateway_services
     tags: services
   - role: gateway_role_user_assignments
-    var: role_user_assignments_list
+    var: gateway_role_user_assignments
     tags: role_user_assignments
   - role: gateway_routes
-    var: routes_list
+    var: gateway_routes
     tags: routes
   - role: gateway_teams
     var: aap_teams
@@ -62,9 +62,12 @@ ah_configuration_dispatcher_roles:
   - role: hub_ee_image
     var: ah_ee_images
     tags: images
+  - role: hub_ee_registry
+    var: ah_ee_registries
+    tags: registry
   - role: hub_ee_registry_index
     var: ah_ee_registries
-    tags: indices
+    tags: ee_indices
   - role: hub_ee_registry_sync
     var: ah_ee_registries
     tags: regsync
@@ -163,9 +166,9 @@ eda_configuration_dispatcher_roles:
   - role: eda_projects
     var: eda_projects
     tags: project
-  # - role: eda_project_sync
-  #   var: eda_projects
-  #   tags: project_sync
+  - role: eda_project_sync
+    var: eda_projects
+    tags: project_sync
   - role: eda_decision_environments
     var: eda_decision_environments
     tags: decision_environment

roles/gateway_applications/defaults/main.yml

@@ -5,5 +5,6 @@ gateway_applications_secure_logging: "{{ aap_configuration_secure_logging | defa
 gateway_applications_async_retries: "{{ aap_configuration_async_retries | default(30) }}"
 gateway_applications_async_delay: "{{ aap_configuration_async_delay | default(1) }}"
 gateway_applications_enforce_defaults: "{{ aap_configuration_enforce_defaults | default(false) }}"
+aap_applications_loop_delay: "{{ aap_configuration_loop_delay | default(0) }}"
 aap_configuration_async_dir: null
 ...

roles/gateway_applications/tasks/main.yml

@@ -27,7 +27,7 @@
   loop_control:
     loop_var: __gateway_application_item
     label: "{{ __operation.verb }} AAP Platform Applications {{ __gateway_application_item.name }}"
-    pause: "{{ gateway_applications_loop_delay }}"
+    pause: "{{ aap_applications_loop_delay }}"
   no_log: "{{ gateway_applications_secure_logging }}"
   async: "{{ ansible_check_mode | ternary(0, 1000) }}"
   poll: 0
@@ -47,9 +47,9 @@
   loop: "{{ __gateway_applications_job_async.results }}"
   loop_control:
     loop_var: __gateway_applications_job_async_results_item
-    label: "{{ __operation.verb }} AAP Platform Applications {{ __gateway_applications_job_async_result.__gateway_application_item.name }} | Wait for finish the Applications {{ __operation.action }}"
+    label: "{{ __operation.verb }} AAP Platform Applications {{ __gateway_applications_job_async_results_item.__gateway_application_item.name }} | Wait for finish the Applications {{ __operation.action }}"
   when: __gateway_applications_job_async_results_item.ansible_job_id is defined
-  no_log: "{{ applications_secure_logging }}"
+  no_log: "{{ gateway_applications_secure_logging }}"
   vars:
     __operation: "{{ operation_translate[__gateway_applications_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir }}"

roles/gateway_authenticator_maps/defaults/main.yml

@@ -13,4 +13,6 @@ gateway_authenticator_maps: []
 gateway_authenticator_maps_secure_logging: "{{ aap_configuration_secure_logging | default(false) }}"
 gateway_authenticator_maps_async_retries: "{{ aap_configuration_async_retries | default(30) }}"
 gateway_authenticator_maps_async_delay: "{{ aap_configuration_async_delay | default(1) }}"
+gateway_authenticator_maps_loop_delay: "{{ aap_configuration_loop_delay | default(0) }}"
+aap_configuration_async_dir: null
 ...

roles/gateway_authenticator_maps/tasks/main.yml

@@ -45,7 +45,7 @@
   loop: "{{ __gateway_authenticator_maps_job_async.results }}"
   loop_control:
     loop_var: __gateway_authenticator_maps_job_async_results_item
-    label: "{{ __operation.verb }} AAP Platform Authenticator Maps {{ __gateway_authenticator_maps_job_async_result.__gateway_authenticator_maps_item.name }} | Wait for finish the Authenticator Map {{ __operation.action }}"
+    label: "{{ __operation.verb }} AAP Platform Authenticator Maps {{ __gateway_authenticator_maps_job_async_results_item.__gateway_authenticator_maps_item.name }} | Wait for finish the Authenticator Map {{ __operation.action }}"
   when: __gateway_authenticator_maps_job_async_results_item.ansible_job_id is defined
   no_log: "{{ gateway_authenticator_maps_secure_logging }}"
   vars:

roles/gateway_authenticators/tasks/main.yml

@@ -43,7 +43,7 @@
   loop: "{{ __gateway_authenticators_job_async.results }}"
   loop_control:
     loop_var: __gateway_authenticators_job_async_results_item
-    label: "{{ __operation.verb }} AAP Platform Authenticators {{ __gateway_authenticators_job_async_result.__gateway_authenticators_item.name }} | Wait for finish the Authenticators {{ __operation.action }}"
+    label: "{{ __operation.verb }} AAP Platform Authenticators {{ __gateway_authenticators_job_async_results_item.__gateway_authenticators_item.name }} | Wait for finish the Authenticators {{ __operation.action }}"
   when: __gateway_authenticators_job_async_results_item.ansible_job_id is defined
   no_log: "{{gateway_authenticators_secure_logging }}"
   vars:

roles/gateway_organizations/meta/argument_specs.yml

@@ -8,22 +8,22 @@ argument_specs:
         type: list
         required: true
         elements: dict
-        options:
-          name:
-            required: true
-            type: str
-            description: Name of the resource
-          new_name:
-            type: str
-            description: Setting this option will change the existing name (looked up via the name field)
-          description:
-            type: str
-            description: Description of the organization
-          state:
-            default: "{{ platform_state | default('present') }}"
-            required: false
-            type: str
-            description: Desired state of the resource.
+        # options:
+        #   name:
+        #     required: true
+        #     type: str
+        #     description: Name of the resource
+        #   new_name:
+        #     type: str
+        #     description: Setting this option will change the existing name (looked up via the name field)
+        #   description:
+        #     type: str
+        #     description: Description of the organization
+        #   state:
+        #     default: "{{ platform_state | default('present') }}"
+        #     required: false
+        #     type: str
+        #     description: Desired state of the resource.
 
       # Async variables
       gateway_organizations_async_retries:

roles/gateway_organizations/tasks/main.yml

@@ -1,10 +1,10 @@
 ---
 - name: Organizations | Configuration # noqa fqcn[action-core]
   ansible.platform.organization:
-    name: "{{ __gateway_organizations_item.name | mandatory }}"
-    new_name: "{{ __gateway_organizations_item.new_name | default(omit) }}"
-    description: "{{ __gateway_organizations_item.description | default(omit) }}"
-    state: "{{ __gateway_organizations_item.state | default(platform_state | default(omit, true)) }}"
+    name: "{{ __gateway_organization_item.name | mandatory }}"
+    new_name: "{{ __gateway_organization_item.new_name | default(omit) }}"
+    description: "{{ __gateway_organization_item.description | default(omit) }}"
+    state: "{{ __gateway_organization_item.state | default(platform_state | default(omit, true)) }}"
 
     # Role Standard Options
     gateway_hostname: "{{ aap_hostname | default(omit, true) }}"
@@ -15,16 +15,16 @@
     gateway_validate_certs: "{{ aap_validate_certs | default(omit) }}"
   loop: "{{ aap_organizations }}"
   loop_control:
-    loop_var: __gateway_organizations_item
-    label: "{{ __operation.verb }} AAP Platform Organizations {{ __gateway_organizations_item.name }}"
+    loop_var: __gateway_organization_item
+    label: "{{ __operation.verb }} AAP Platform Organizations {{ __gateway_organization_item.name }}"
     pause: "{{ gateway_organizations_loop_delay }}"
   no_log: "{{ gateway_organizations_secure_logging }}"
   async: 1000
   poll: 0
   register: __gateway_organizations_job_async
   changed_when: not __gateway_organizations_job_async.changed
   vars:
-    __operation: "{{ operation_translate[__gateway_organizations_item.state | default(platform_state) | default('present')] }}"
+    __operation: "{{ operation_translate[__gateway_organization_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir }}"
 
 - name: Organizations | Wait for finish the configuration
@@ -37,7 +37,7 @@
   loop: "{{ __gateway_organizations_job_async.results }}"
   loop_control:
     loop_var: __gateway_organizations_job_async_results_item
-    label: "{{ __operation.verb }} AAP Platform Organizations {{ __gateway_organizations_job_async_result.__gateway_organizations_item.name }} | Wait for finish the Organizations {{ __operation.action }}"
+    label: "{{ __operation.verb }} AAP Platform Organizations {{ __gateway_organizations_job_async_result.__gateway_organizations_job_async_results_item.__gateway_organization_item.name }} | Wait for finish the Organizations {{ __operation.action }}"
   when: __gateway_organizations_job_async_results_item.ansible_job_id is defined
   no_log: "{{ gateway_organizations_secure_logging }}"
   vars:

roles/gateway_routes/defaults/main.yml

@@ -9,7 +9,7 @@
 # These are the default variables specific to the license role
 
 # a list of dictionaries describing the service nodes
-gateway_gateway_routes: []
+gateway_routes: []
 gateway_routes_secure_logging: "{{ aap_configuration_secure_logging | default('false') }}"
 gateway_routes_async_retries: "{{ aap_configuration_async_retries | default(30) }}"
 gateway_routes_async_delay: "{{ aap_configuration_async_delay | default(1) }}"

roles/gateway_service_clusters/defaults/main.yml

@@ -10,6 +10,7 @@
 
 # a list of dictionaries describing the service clusters
 gateway_service_clusters: []
+gateway_service_clusters_secure_logging: "{{ aap_configuration_secure_logging | default(false) }}"
 gateway_service_clusters_async_retries: "{{ aap_configuration_async_retries | default(30) }}"
 gateway_service_clusters_async_delay: "{{ aap_configuration_async_delay | default(1) }}"
 gateway_service_clusters_loop_delay: "{{ aap_configuration_loop_delay | default(0) }}"