Skip to content

Commit 461ac7f

Browse files
committed
Clarify the active state and admin fields in the Ban model.
1 parent f37af2d commit 461ac7f

File tree

1 file changed

+20
-2
lines changed

1 file changed

+20
-2
lines changed

src/Models/Ban.php

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,12 @@ class Ban extends Model
2222
protected Carbon $timeAdded;
2323

2424
/**
25-
* If the ban is still active.
25+
* If the ban is still active or was disabled.
26+
*
27+
* When a ban was issued by mistake, staff may deactivate it manually, but
28+
* it still shows as inactive in the ban history.
29+
*
30+
* Does not change if the ban expires naturally on the expiration date.
2631
*
2732
* @var bool
2833
*/
@@ -38,13 +43,17 @@ class Ban extends Model
3843
/**
3944
* The name of the admin that banned the user.
4045
*
46+
* This field is generally redacted when accessing the public API.
47+
*
4148
* @var string
4249
*/
4350
protected string $adminName;
4451

4552
/**
4653
* The TruckersMP ID for the admin that banned the user.
4754
*
55+
* This field is generally redacted when accessing the public API.
56+
*
4857
* @var int
4958
*/
5059
protected int $adminId;
@@ -98,7 +107,12 @@ public function getCreatedAt(): Carbon
98107
}
99108

100109
/**
101-
* Determine if the ban is active or not.
110+
* Determine if the ban is active or was disabled.
111+
*
112+
* When a ban was issued by mistake, staff may deactivate it manually, but
113+
* it still shows as inactive in the ban history.
114+
*
115+
* Does not change if the ban expires naturally on the expiration date.
102116
*
103117
* @return bool
104118
*/
@@ -120,6 +134,8 @@ public function getReason(): string
120134
/**
121135
* Get the name of the admin who banned the player.
122136
*
137+
* This field is generally redacted when accessing the public API.
138+
*
123139
* @return string
124140
*/
125141
public function getAdminName(): string
@@ -130,6 +146,8 @@ public function getAdminName(): string
130146
/**
131147
* Get the TMP ID of the admin who banned the player.
132148
*
149+
* This field is generally redacted when accessing the public API.
150+
*
133151
* @return int
134152
*/
135153
public function getAdminId(): int

0 commit comments

Comments
 (0)