StatsHouse UI: fix legend show line

Author: vauweb

statshouse-ui/src/components2/PlotWidgets/MetricWidget/MetricWidget.tsx

@@ -19,7 +19,7 @@ import {
   UPlotWrapperPropsOpts,
   UPlotWrapperPropsScales,
 } from '@/components/UPlotWrapper';
-import type { PlotData, PlotValues } from '@/store2/plotDataStore';
+import type { PlotValues } from '@/store2/plotDataStore';
 import { setLiveMode } from '@/store2/liveModeStore';
 import { formatByMetricType, getMetricType } from '@/common/formatByMetricType';
 import { dataIdxNearest } from '@/common/dataIdxNearest';
@@ -43,7 +43,6 @@ import { rightPad, syncGroup, unFocusAlfa, yLockDefault } from '@/components2/Pl
 import { useMetricName } from '@/hooks/useMetricName';
 import { useMetricMeta } from '@/hooks/useMetricMeta';
 import { useMetricData } from '@/hooks/useMetricData';
-import { produce } from 'immer';
 import { resetZoom, setPlotYLock, setTimeRange } from '@/store2/methods';
 import { PlotBox } from '@/components2/Plot/PlotView/PlotBox';
 
@@ -312,16 +311,14 @@ export function MetricWidget({ className, isDashboard, isEmbed, fixRatio }: Plot
   const onLegendShow = useCallback(
     (index: number, show: boolean, single: boolean) => {
       const idx = index - 1;
-      setData(
-        produce<PlotData>((d) => {
-          if (single) {
-            const otherShow = d.seriesShow.some((_show, indexSeries) => (indexSeries === idx ? false : _show));
-            d.seriesShow = d.seriesShow.map((_, indexSeries) => (indexSeries === idx ? true : !otherShow));
-          } else {
-            d.seriesShow[idx] = show ?? !d.seriesShow[idx];
-          }
-        })
-      );
+      setData((d) => {
+        if (single) {
+          const otherShow = d.seriesShow.some((_show, indexSeries) => (indexSeries === idx ? false : _show));
+          d.seriesShow = d.seriesShow.map((_, indexSeries) => (indexSeries === idx ? true : !otherShow));
+        } else {
+          d.seriesShow[idx] = show ?? !d.seriesShow[idx];
+        }
+      });
     },
     [setData]
   );

statshouse-ui/src/store2/plotDataStore/normalizePlotData.ts

@@ -156,7 +156,9 @@ export function normalizePlotData(
       const label = totalLineId !== indexMeta ? metaToLabel(meta, uniqueWhat.size) : totalLineLabel;
       const baseLabel = totalLineId !== indexMeta ? metaToBaseLabel(meta, uniqueWhat.size) : totalLineLabel;
       const isValue = baseLabel.indexOf('Value') === 0;
-
+      if (plotData.series[indexMeta]?.label === baseLabel) {
+        seriesShow[indexMeta] = plotData.seriesShow[indexMeta];
+      }
       const metricName = isValue ? `${meta.name || (plot.metricName !== promQLMetric ? plot.metricName : '')}: ` : '';
       const colorKey = `${prefColor}${metricName}${oneGraph ? label : baseLabel}`;
       // client select color line