This repository was archived by the owner on Aug 14, 2019. It is now read-only.

Description
See also #3
Currently, the row actions links are rendered as links, for example:
<a aria-label="Unapprove this comment" class="vim-u vim-destructive" href="#">Unapprove</a>
However, they don't point to a real resource, instead they perform an action. Also, as far as I see there's no "Edit" screen to point to any longer, that was one of the very few cases where a link was appropriate. Many of these links in WordPress are still inks because of the no-js fallback: when JS is disabled they actually behave like links. In this case though, everything is JS-based so they should be buttons.
See also the decision logic summarized in the a11y standards: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#semantics-for-controls
Making them buttons will also give a little advantage: no need to pass the event to prevent the default links action (scroll because of the # anchor).