Skip to content

Commit de7566d

Browse files
committed
Fix Cygwin toolchain build to be compatible with upstream workflow
1 parent e8aad8c commit de7566d

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

.github/scripts/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ fi
5151

5252
$ROOT_PATH/.github/scripts/toolchain/build-gcc.sh
5353

54-
if [[ "$PLATFORM" =~ (mingw|cygwin) ]]; then
54+
if [[ "$PLATFORM" =~ mingw ]]; then
5555
$ROOT_PATH/.github/scripts/toolchain/build-mingw.sh
5656
fi
5757
if [[ "$PLATFORM" =~ cygwin ]]; then

.github/scripts/config.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ MINGW_REPO=${MINGW_REPO:-Windows-on-ARM-Experiments/mingw-woarm64}
1515
MINGW_BRANCH=${MINGW_BRANCH:-woarm64}
1616

1717
CYGWIN_REPO=${CYGWIN_REPO:-Windows-on-ARM-Experiments/newlib-cygwin}
18-
CYGWIN_BRANCH=${CYGWIN_BRANCH:-woarm64}
18+
CYGWIN_BRANCH=${CYGWIN_BRANCH:-upstream-workflow}
1919

2020
CYGWIN_PACKAGES_REPO=${CYGWIN_PACKAGES_REPO:-Windows-on-ARM-Experiments/cygwin-packages}
2121
CYGWIN_PACKAGES_BRANCH=${CYGWIN_PACKAGES_BRANCH:-main}

.github/scripts/toolchain/build-mingw-headers.sh

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,15 @@ if [[ "$RUN_CONFIG" = 1 ]] || [[ ! -f "$MINGW_HEADERS_BUILD_PATH/Makefile" ]]; t
2121
TARGET_OPTIONS="$TARGET_OPTIONS \
2222
--enable-w32api"
2323
;;
24-
*mingw*)
25-
TARGET_OPTIONS="$TARGET_OPTIONS \
26-
--enable-sdk=all"
27-
;;
2824
esac
2925

30-
case "$CRT" in
31-
ucrt)
26+
case "$PLATFORM-$CRT" in
27+
*mingw*-ucrt)
3228
TARGET_OPTIONS="$TARGET_OPTIONS \
3329
--with-default-win32-winnt=0x603 \
3430
--with-default-msvcrt=ucrt"
3531
;;
36-
msvcrt)
32+
*mingw*-msvcrt)
3733
TARGET_OPTIONS="$TARGET_OPTIONS \
3834
--with-default-win32-winnt=0x601 \
3935
--with-default-msvcrt=msvcrt"
@@ -44,6 +40,7 @@ if [[ "$RUN_CONFIG" = 1 ]] || [[ ! -f "$MINGW_HEADERS_BUILD_PATH/Makefile" ]]; t
4440
--prefix=$TOOLCHAIN_PATH/$TARGET \
4541
--build=$BUILD \
4642
--host=$TARGET \
43+
--enable-sdk=all \
4744
$HOST_OPTIONS \
4845
$TARGET_OPTIONS
4946
echo "::endgroup::"

.github/workflows/advanced.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ env:
7878
MINGW_BRANCH: ${{ inputs.mingw_branch || 'woarm64' }}
7979

8080
CYGWIN_REPO: Windows-on-ARM-Experiments/newlib-cygwin
81-
CYGWIN_BRANCH: ${{ inputs.cygwin_branch || 'woarm64' }}
81+
CYGWIN_BRANCH: ${{ inputs.cygwin_branch || 'upstream-workflow' }}
8282

8383
CYGWIN_PACKAGES_REPO: Windows-on-ARM-Experiments/cygwin-packages
8484
CYGWIN_PACKAGES_BRANCH: ${{ inputs.cygwin_packages_branch || 'main' }}
@@ -320,7 +320,7 @@ jobs:
320320
.github/scripts/toolchain/build-gcc.sh
321321
322322
- name: Build MinGW
323-
if: ${{ steps.cache-toolchain.outputs.cache-hit != 'true' && matrix.platform != 'pc-linux-gnu' }}
323+
if: ${{ steps.cache-toolchain.outputs.cache-hit != 'true' && matrix.platform == 'w64-mingw32' }}
324324
run: |
325325
.github/scripts/toolchain/build-mingw.sh
326326

0 commit comments

Comments
 (0)