Merge pull request #495 from abraham/copilot/remove-grouped-notifications-results

Remove GroupedNotificationsResults special case

Author: abraham

src/__tests__/generators/EntityConverter.grouped-notifications.test.ts

@@ -4,7 +4,7 @@ import { UtilityHelpers } from '../../generators/UtilityHelpers';
 import { EntityClass } from '../../interfaces/EntityClass';
 import { OpenAPISpec } from '../../interfaces/OpenAPISchema';
 
-describe('EntityConverter - GroupedNotificationsResults Special Case', () => {
+describe('EntityConverter - GroupedNotificationsResults', () => {
   let entityConverter: EntityConverter;
   let utilityHelpers: UtilityHelpers;
   let typeParser: TypeParser;
@@ -39,7 +39,7 @@ describe('EntityConverter - GroupedNotificationsResults Special Case', () => {
         attributes: [
           {
             name: 'notification_groups',
-            type: '[NotificationGroup]',
+            type: 'Array of [NotificationGroup]',
             description: 'The grouped notifications themselves.',
             optional: false,
             nullable: true,
@@ -114,7 +114,7 @@ describe('EntityConverter - GroupedNotificationsResults Special Case', () => {
         attributes: [
           {
             name: 'notification_groups',
-            type: '[NotificationGroup]',
+            type: 'Array of [NotificationGroup]',
             description: 'The grouped notifications themselves.',
             optional: false,
             nullable: false,

src/generators/EntityConverter.ts

@@ -73,21 +73,6 @@ class EntityConverter {
             ...entity.attributes,
           ];
         }
-      } else if (entity.name === 'GroupedNotificationsResults') {
-        // Special case: notification_groups should be an array of NotificationGroup
-        // The documentation incorrectly states it's a single NotificationGroup,
-        // but the actual API returns an array (as shown in the JSON examples).
-        // This is a known documentation bug that needs to be corrected here.
-        // See: https://github.com/mastodon/documentation/blob/main/content/en/methods/grouped_notifications.md
-        allAttributes = entity.attributes.map((attr) => {
-          if (attr.name === 'notification_groups') {
-            return {
-              ...attr,
-              type: 'Array of [NotificationGroup]',
-            };
-          }
-          return attr;
-        });
       }
 
       const schema: OpenAPISchema = {