Skip to content

Commit 282c236

Browse files
committed
fix(template) Adjust current time handling in API
Signed-off-by: Jerome Simeon <[email protected]>
1 parent 029c3ed commit 282c236

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

packages/markdown-template/lib/TemplateMarkTransformer.js

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414

1515
'use strict';
1616

17-
const datetimeutil = require('./datetimeutil');
18-
1917
const { ParseException } = require('@accordproject/concerto-core');
2018
const {
2119
templateMarkManager,
@@ -195,8 +193,7 @@ class TemplateMarkTransformer {
195193
fromCiceroMark(input, templateMark, modelManager, templateKind, currentTime, options) {
196194
// Construct the template parser
197195
const parserManager = new ParserManager(modelManager,this.parsingTable,templateKind);
198-
const momentTime = datetimeutil.setCurrentTime(currentTime);
199-
parserManager.setCurrentTime(momentTime);
196+
parserManager.setCurrentTime(currentTime);
200197
parserManager.setTemplateMark(templateMark);
201198
parserManager.buildParser();
202199

@@ -228,20 +225,19 @@ class TemplateMarkTransformer {
228225
* @param {*} data the contract/clause data input
229226
* @param {*} parserManager - the parser manager for this template
230227
* @param {string} templateKind - either 'clause' or 'contract'
231-
* @param {string} currentTime - the definition of 'now'
232228
* @param {object} [options] configuration options
233229
* @param {boolean} [options.verbose] verbose output
234230
* @returns {object} the result
235231
*/
236-
draftCiceroMark(data, parserManager, templateKind, currentTime, options) {
232+
draftCiceroMark(data, parserManager, templateKind, options) {
237233
const parameters = {
238234
parserManager: parserManager,
239235
templateMarkModelManager: templateMarkManager.modelManager,
240236
templateMarkSerializer: templateMarkManager.serializer,
241237
fullData: data,
242238
data: data,
243239
kind: templateKind,
244-
currentTime: currentTime,
240+
currentTime: parserManager.getCurrentTime(),
245241
};
246242

247243
const input = templateMarkManager.serializer.fromJSON(parserManager.getTemplateMark());
@@ -267,10 +263,10 @@ class TemplateMarkTransformer {
267263
*/
268264
instantiateCiceroMark(data, templateMark, modelManager, templateKind, currentTime, options) {
269265
// Construct the template parser
270-
const momentTime = datetimeutil.setCurrentTime(currentTime);
271266
const parserManager = new ParserManager(modelManager, this.parsingTable, templateKind);
267+
parserManager.setCurrentTime(currentTime);
272268
parserManager.setTemplateMark(templateMark);
273-
return this.draftCiceroMark(data, parserManager, templateKind, momentTime, options);
269+
return this.draftCiceroMark(data, parserManager, templateKind, options);
274270
}
275271

276272
}

packages/markdown-template/lib/parsermanager.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
'use strict';
1616

17-
const moment = require('moment-mini');
17+
const datetimeutil = require('./datetimeutil');
1818

1919
const { Factory, Serializer } = require('@accordproject/concerto-core');
2020

@@ -61,7 +61,7 @@ class ParserManager {
6161
this.templateMark = null;
6262
this.parser = null;
6363
this.templateKind = templateKind ? templateKind : 'clause';
64-
this.currentTime = moment();
64+
this.currentTime = datetimeutil.setCurrentTime(null); // Default setting to now
6565

6666
// Mapping from types to parsers/drafters
6767
this.parserVisitor = new ToParserVisitor();
@@ -212,7 +212,7 @@ class ParserManager {
212212
* @param {string} currentTime the current time
213213
*/
214214
setCurrentTime(currentTime) {
215-
this.currentTime = currentTime;
215+
this.currentTime = datetimeutil.setCurrentTime(currentTime);
216216
}
217217

218218
/**

0 commit comments

Comments
 (0)