-
Notifications
You must be signed in to change notification settings - Fork 56
Open
Labels
Difficulty: ChallengingType: Enhancement ✨Improvement to process or efficiencyImprovement to process or efficiency
Description
Discussion 🗣
Currently, the transformer for converting OOXML<->CiceroMark is quite big. The issue aims at dealing with refactoring it to reduce the size keeping the logic intact.
Context
Things to look at while refactoring:
- More suitable naming for variables or functions
-
traverseNodes(): merge the 4th argument-parent propertiesinto thepropertiesargument and necessary changes in code for proper functioning. The reason beingparent propertiesare generally used by nodes so they should be present in thepropertiesitself. -
generateTextOrCodeOOXML(): merge the 4th argument-parent propertiesinto thepropertiesargument and necessary changes in code for proper functioning. Same reason as above. - The tests currently for
markdown-docxinalgo-ooxmlbranch are uglified. Prettify all the tests.
Any other thing that can be refactored.
Detailed Description
The need for this issue arose during PR #441. Due to lack of time, the current implementation was done to launch a working transformer.
Metadata
Metadata
Assignees
Labels
Difficulty: ChallengingType: Enhancement ✨Improvement to process or efficiencyImprovement to process or efficiency