-
Notifications
You must be signed in to change notification settings - Fork 17
Fix start command in build instructions #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Following the existing instructions I got this: ``` ❯ bun run build $ bun build --target=node --format=esm --bundle --sourcemap --outdir=build ./src/index.ts ./src/server.ts Bundled 329 modules in 34ms index.js 0.96 MB (entry point) server.js 1.78 MB (entry point) index.js.map 1.82 MB (source map) server.js.map 2.98 MB (source map) ❯ bun start error: Script not found "start" ```
Summary of ChangesHello @rmoff, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue in the build instructions by correcting the command used to start the application. The previous instruction Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a broken command in the README.md build instructions. The change from bun start to bun run start:http resolves the error reported. My review includes a suggestion to further improve the instructions by running the compiled server artifact instead of the source file, which aligns better with the 'Build and Run' section's intent and improves clarity for users.
| ```bash | ||
| bun run build | ||
| bun start | ||
| bun run start:http |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the broken command. While bun run start:http works, it runs the server from the source TypeScript file. Since the preceding step is bun run build, it's more logical and less confusing for the user to run the compiled JavaScript file that was just created. This makes the 'Build and Run' sequence more intuitive.
| bun run start:http | |
| bun build/server.js |
Following the existing instructions I got this: