don't need this error checking

Author: adorton-adobe

tests/test_functional.py

@@ -247,25 +247,13 @@ def test_add_users():
                                  "usergroup": "SampleUsers"}
 
 
-def test_add_users_error():
-    group = GroupAction(group_name="SampleUsers")
-    with pytest.raises(ValueError):
-        group.add_users(users=[])
-
-
 def test_remove_users():
     group = GroupAction(group_name="SampleUsers")
     group.remove_users(users=["[email protected]", "[email protected]"])
     assert group.wire_dict() == {"do": [{"remove": {"user": ["[email protected]", "[email protected]"]}}],
                                  "usergroup": "SampleUsers"}
 
 
-def test_remove_users_error():
-    group = GroupAction(group_name="SampleUsers")
-    with pytest.raises(ValueError):
-        group.remove_users(users=[])
-
-
 def test_create_user_group():
     group = GroupAction(group_name="Test Group")
     group.create(description="Test Group Description")

umapi_client/functional.py

@@ -255,28 +255,24 @@ def remove_from_products(self, products):
         plist = {"productConfiguration": list(products)}
         return self.append(remove=plist)
 
-    def add_users(self, users=None):
+    def add_users(self, users):
         """
         Add users (specified by email address) to this user group.
         In case of ambiguity (two users with same email address), the non-AdobeID user is preferred.
         :param users: list of emails for users to add to the group.
         :return: the Group, so you can do Group(...).add_users(...).add_to_products(...)
         """
-        if not users:
-            raise ArgumentError("You must specify emails for users to add to the user group")
-        ulist = {"user": [user for user in users]}
+        ulist = {"user": list(users)}
         return self.append(add=ulist)
 
-    def remove_users(self, users=None):
+    def remove_users(self, users):
         """
         Remove users (specified by email address) from this user group.
         In case of ambiguity (two users with same email address), the non-AdobeID user is preferred.
         :param users: list of emails for users to remove from the group.
         :return: the Group, so you can do Group(...).remove_users(...).add_to_products(...)
         """
-        if not users:
-            raise ArgumentError("You must specify emails for users to remove from the user group")
-        ulist = {"user": [user for user in users]}
+        ulist = {"user": list(users)}
         return self.append(remove=ulist)
 
     def create(self, option=IfAlreadyExistsOption.ignoreIfAlreadyExists, description=None):