review comments

Author: tkotthakota-adobe

README.md

@@ -27,7 +27,7 @@ SpaceCat Task Processor is a Node.js service that processes messages from the AW
 1. Clone the repository
 2. Install dependencies:
    ```sh
-   npm ci
+   npm install
    ```
 3. Configure AWS credentials and environment variables as needed
 

scripts/populate-env.sh

@@ -11,7 +11,6 @@
  */
 import wrap from '@adobe/helix-shared-wrap';
 import { helixStatus } from '@adobe/helix-status';
-import secrets from '@adobe/helix-shared-secrets';
 import dataAccess from '@adobe/spacecat-shared-data-access';
 import { sqsEventAdapter } from '@adobe/spacecat-shared-utils';
 import { internalServerError, notFound, ok } from '@adobe/spacecat-shared-http-utils';
@@ -27,14 +26,6 @@ const HANDLERS = {
   dummy: (message) => ok(message),
 };
 
-// Custom secret name resolver to use the correct secret path
-function getSecretName() {
-  return '/helix-deploy/spacecat-services/api-service/latest';
-}
-
-// Export for testing
-export { getSecretName };
-
 function getElapsedSeconds(startTime) {
   const endTime = process.hrtime(startTime);
   const elapsedSeconds = endTime[0] + endTime[1] / 1e9;
@@ -76,5 +67,4 @@ async function run(message, context) {
 export const main = wrap(run)
   .with(dataAccess)
   .with(sqsEventAdapter)
-  .with(secrets, { name: getSecretName })
   .with(helixStatus);

scripts/watch-and-copy.js

@@ -16,8 +16,8 @@ import { say } from '../../utils/slack-utils.js';
 const TASK_TYPE = 'demo-url-processor';
 
 /**
- * Runs the audit status processor
- * @param {object} demoUrlMessage - The demoUrlMessage object
+ * Runs the demo url processor
+ * @param {object} message - The message object
  * @param {object} context - The context object
  */
 export async function runDemoUrlProcessor(message, context) {

src/index.js

@@ -62,7 +62,7 @@ export async function runOpportunityStatusProcessor(message, context) {
 
   try {
     // Get the site and its opportunities
-    const site = await Site.findByBaseURL(`https://${siteId}.com`);
+    const site = await Site.findById(siteId);
     if (!site) {
       log.error(`Site not found for siteId: ${siteId}`);
       await say(env, log, slackContext, `:x: Site not found for siteId: ${siteId}`);
@@ -83,10 +83,8 @@ export async function runOpportunityStatusProcessor(message, context) {
         continue;
       }
       processedTypes.add(opportunityType);
-
       // eslint-disable-next-line no-await-in-loop
       const suggestions = await opportunity.getSuggestions();
-
       // Get the opportunity title
       const opportunityTitle = getOpportunityTitle(opportunityType);
       const hasSuggestions = suggestions && suggestions.length > 0;

src/tasks/demo-url-processor/handler.js

@@ -17,7 +17,7 @@ import sinon from 'sinon';
 import sinonChai from 'sinon-chai';
 import { Request } from '@adobe/fetch';
 import esmock from 'esmock';
-import { main, getSecretName } from '../src/index.js';
+import { main } from '../src/index.js';
 
 use(sinonChai);
 
@@ -97,18 +97,10 @@ describe('Index Tests', () => {
     expect(resp.status).to.equal(200);
     // Verify the task handler was found
     expect(context.log.info.calledWith('Found task handler for type: dummy')).to.be.true;
-    // Print all log.info calls for debugging
-    // eslint-disable-next-line no-console
-    console.log('log.info calls:', context.log.info.getCalls().map((call) => call.args[0]));
     // Verify the task completion message (using partial match since timing varies)
     expect(context.log.info.calledWithMatch(sinon.match('dummy task for site-id completed in'))).to.be.true;
   });
 
-  it('should cover getSecretName function', () => {
-    const secretName = getSecretName();
-    expect(secretName).to.equal('/helix-deploy/spacecat-services/api-service/latest');
-  });
-
   it('should handle handler throwing an error', async () => {
     // Test a handler type that doesn't exist to trigger the catch block
     messageBodyJson.type = 'opportunity-status-processor';

src/tasks/opportunity-status-processor/handler.js

@@ -47,7 +47,7 @@ describe('Opportunity Status Processor', () => {
       .withSandbox(sandbox)
       .withDataAccess({
         Site: {
-          findByBaseURL: sandbox.stub().resolves(mockSite),
+          findById: sandbox.stub().resolves(mockSite),
         },
       })
       .build();
@@ -91,13 +91,13 @@ describe('Opportunity Status Processor', () => {
         auditTypes: ['cwv', 'broken-links'],
       })).to.be.true;
 
-      expect(context.dataAccess.Site.findByBaseURL.calledWith('https://test-site-id.com')).to.be.true;
+      expect(context.dataAccess.Site.findById.calledWith('test-site-id')).to.be.true;
       expect(mockSite.getOpportunities.called).to.be.true;
       expect(context.log.info.calledWith('Found 2 opportunities for site test-site-id')).to.be.true;
     });
 
     it('should handle site not found error', async () => {
-      context.dataAccess.Site.findByBaseURL.resolves(null);
+      context.dataAccess.Site.findById.resolves(null);
 
       await runOpportunityStatusProcessor(message, context);