Skip to content

Commit 2aa8771

Browse files
thetutlagethetutlage
committed
fix: do not put HTTP methods in quotes when generating types
1 parent 5f9ea74 commit 2aa8771

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

‎src/router/main.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -711,7 +711,7 @@ export class Router {
711711

712712
return Object.keys(routesList)
713713
.reduce<string[]>((result, method) => {
714-
result.push(`${' '.repeat(indentation)}'${method}': {`)
714+
result.push(`${' '.repeat(indentation)}${method}: {`)
715715

716716
Object.keys(routesList[method]).forEach((identifier) => {
717717
const key = `'${identifier}'`

‎tests/router/router.spec.ts‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1588,7 +1588,7 @@ test.group('Router | generateTypes', () => {
15881588

15891589
router.commit()
15901590
assert.snapshot(router.generateTypes()).matchInline(`
1591-
"'ALL': {
1591+
"ALL: {
15921592
'api.posts.index': { paramsTuple?: [], params?: {} },
15931593
'api.posts.create': { paramsTuple?: [], params?: {} },
15941594
'api.posts.store': { paramsTuple?: [], params?: {} },
@@ -1598,30 +1598,30 @@ test.group('Router | generateTypes', () => {
15981598
'api.posts.destroy': { paramsTuple: [string], params: {'id': string} },
15991599
'comments.index': { paramsTuple?: [], params?: {} },
16001600
},
1601-
'GET': {
1601+
GET: {
16021602
'api.posts.index': { paramsTuple?: [], params?: {} },
16031603
'api.posts.create': { paramsTuple?: [], params?: {} },
16041604
'api.posts.show': { paramsTuple: [string], params: {'id': string} },
16051605
'api.posts.edit': { paramsTuple: [string], params: {'id': string} },
16061606
'comments.index': { paramsTuple?: [], params?: {} },
16071607
},
1608-
'HEAD': {
1608+
HEAD: {
16091609
'api.posts.index': { paramsTuple?: [], params?: {} },
16101610
'api.posts.create': { paramsTuple?: [], params?: {} },
16111611
'api.posts.show': { paramsTuple: [string], params: {'id': string} },
16121612
'api.posts.edit': { paramsTuple: [string], params: {'id': string} },
16131613
'comments.index': { paramsTuple?: [], params?: {} },
16141614
},
1615-
'POST': {
1615+
POST: {
16161616
'api.posts.store': { paramsTuple?: [], params?: {} },
16171617
},
1618-
'PUT': {
1618+
PUT: {
16191619
'api.posts.update': { paramsTuple: [string], params: {'id': string} },
16201620
},
1621-
'PATCH': {
1621+
PATCH: {
16221622
'api.posts.update': { paramsTuple: [string], params: {'id': string} },
16231623
},
1624-
'DELETE': {
1624+
DELETE: {
16251625
'api.posts.destroy': { paramsTuple: [string], params: {'id': string} },
16261626
},"
16271627
`)
@@ -1650,7 +1650,7 @@ test.group('Router | generateTypes', () => {
16501650

16511651
router.commit()
16521652
assert.snapshot(router.generateTypes()).matchInline(`
1653-
"'ALL': {
1653+
"ALL: {
16541654
'api.posts.index': { paramsTuple?: [], params?: {} },
16551655
'api.posts.create': { paramsTuple?: [], params?: {} },
16561656
'api.posts.store': { paramsTuple?: [], params?: {} },
@@ -1666,7 +1666,7 @@ test.group('Router | generateTypes', () => {
16661666
'[email protected]': { paramsTuple: [string], params: {'id': string} },
16671667
'[email protected]': { paramsTuple: [string], params: {'id': string} },
16681668
},
1669-
'GET': {
1669+
GET: {
16701670
'api.posts.index': { paramsTuple?: [], params?: {} },
16711671
'api.posts.create': { paramsTuple?: [], params?: {} },
16721672
'api.posts.show': { paramsTuple: [string], params: {'id': string} },
@@ -1676,7 +1676,7 @@ test.group('Router | generateTypes', () => {
16761676
'[email protected]': { paramsTuple: [string], params: {'id': string} },
16771677
'[email protected]': { paramsTuple: [string], params: {'id': string} },
16781678
},
1679-
'HEAD': {
1679+
HEAD: {
16801680
'api.posts.index': { paramsTuple?: [], params?: {} },
16811681
'api.posts.create': { paramsTuple?: [], params?: {} },
16821682
'api.posts.show': { paramsTuple: [string], params: {'id': string} },
@@ -1686,19 +1686,19 @@ test.group('Router | generateTypes', () => {
16861686
'[email protected]': { paramsTuple: [string], params: {'id': string} },
16871687
'[email protected]': { paramsTuple: [string], params: {'id': string} },
16881688
},
1689-
'POST': {
1689+
POST: {
16901690
'api.posts.store': { paramsTuple?: [], params?: {} },
16911691
'[email protected]': { paramsTuple?: [], params?: {} },
16921692
},
1693-
'PUT': {
1693+
PUT: {
16941694
'api.posts.update': { paramsTuple: [string], params: {'id': string} },
16951695
'[email protected]': { paramsTuple: [string], params: {'id': string} },
16961696
},
1697-
'PATCH': {
1697+
PATCH: {
16981698
'api.posts.update': { paramsTuple: [string], params: {'id': string} },
16991699
'[email protected]': { paramsTuple: [string], params: {'id': string} },
17001700
},
1701-
'DELETE': {
1701+
DELETE: {
17021702
'api.posts.destroy': { paramsTuple: [string], params: {'id': string} },
17031703
'[email protected]': { paramsTuple: [string], params: {'id': string} },
17041704
},"
@@ -1730,7 +1730,7 @@ test.group('Router | generateTypes', () => {
17301730

17311731
router.commit()
17321732
assert.snapshot(router.generateTypes()).matchInline(`
1733-
"'ALL': {
1733+
"ALL: {
17341734
'api.posts.index': { paramsTuple?: [], params?: {} },
17351735
'api.posts.create': { paramsTuple?: [], params?: {} },
17361736
'api.posts.store': { paramsTuple?: [], params?: {} },
@@ -1746,7 +1746,7 @@ test.group('Router | generateTypes', () => {
17461746
'api.comments.update': { paramsTuple: [string], params: {'id': string} },
17471747
'api.comments.destroy': { paramsTuple: [string], params: {'id': string} },
17481748
},
1749-
'GET': {
1749+
GET: {
17501750
'api.posts.index': { paramsTuple?: [], params?: {} },
17511751
'api.posts.create': { paramsTuple?: [], params?: {} },
17521752
'api.posts.show': { paramsTuple: [string], params: {'id': string} },
@@ -1756,7 +1756,7 @@ test.group('Router | generateTypes', () => {
17561756
'api.comments.show': { paramsTuple: [string], params: {'id': string} },
17571757
'api.comments.edit': { paramsTuple: [string], params: {'id': string} },
17581758
},
1759-
'HEAD': {
1759+
HEAD: {
17601760
'api.posts.index': { paramsTuple?: [], params?: {} },
17611761
'api.posts.create': { paramsTuple?: [], params?: {} },
17621762
'api.posts.show': { paramsTuple: [string], params: {'id': string} },
@@ -1766,19 +1766,19 @@ test.group('Router | generateTypes', () => {
17661766
'api.comments.show': { paramsTuple: [string], params: {'id': string} },
17671767
'api.comments.edit': { paramsTuple: [string], params: {'id': string} },
17681768
},
1769-
'POST': {
1769+
POST: {
17701770
'api.posts.store': { paramsTuple?: [], params?: {} },
17711771
'api.comments.store': { paramsTuple?: [], params?: {} },
17721772
},
1773-
'PUT': {
1773+
PUT: {
17741774
'api.posts.update': { paramsTuple: [string], params: {'id': string} },
17751775
'api.comments.update': { paramsTuple: [string], params: {'id': string} },
17761776
},
1777-
'PATCH': {
1777+
PATCH: {
17781778
'api.posts.update': { paramsTuple: [string], params: {'id': string} },
17791779
'api.comments.update': { paramsTuple: [string], params: {'id': string} },
17801780
},
1781-
'DELETE': {
1781+
DELETE: {
17821782
'api.posts.destroy': { paramsTuple: [string], params: {'id': string} },
17831783
'api.comments.destroy': { paramsTuple: [string], params: {'id': string} },
17841784
},"

0 commit comments

Comments
 (0)