Merge branch 'master' into fix-mysql8-tests

Author: Nothing4You

CHANGES.txt

@@ -1,9 +1,10 @@
 Changes
 -------
 
-pending release
+To be included in 1.0.0 (unreleased)
 ^^^^^^^^^^^^^^^^^^^
 
+* Don't send sys.argv[0] as program_name to MySQL server by default #620
 * Fix timed out MySQL 8.0 connections raising InternalError rather than OperationalError #660
 * Fix timed out MySQL 8.0 connections being returned from Pool #660
 * Ensure connections are properly closed before raising an OperationalError when the server connection is lost #660

aiomysql/connection.py

@@ -183,7 +183,7 @@ def __init__(self, host="localhost", user=None, password="",
             when using IAM authentication with Amazon RDS.
             (default: Server Default)
         :param program_name: Program name string to provide when
-            handshaking with MySQL. (default: sys.argv[0])
+            handshaking with MySQL. (omitted by default)
         :param server_public_key: SHA256 authentication plugin public
             key value.
         :param loop: asyncio loop
@@ -237,8 +237,6 @@ def __init__(self, host="localhost", user=None, password="",
         }
         if program_name:
             self._connect_attrs["program_name"] = program_name
-        elif sys.argv:
-            self._connect_attrs["program_name"] = sys.argv[0]
 
         self._unix_socket = unix_socket
         if charset:

docs/connection.rst

@@ -88,7 +88,10 @@ Example::
         when using IAM authentication with Amazon RDS.
         (default: Server Default)
     :param program_name: Program name string to provide when
-        handshaking with MySQL. (default: sys.argv[0])
+        handshaking with MySQL. (omitted by default)
+
+        .. versionchanged:: 1.0
+            ``sys.argv[0]`` is no longer passed by default
     :param server_public_key: SHA256 authenticaiton plugin public key value.
     :param loop: asyncio event loop instance or ``None`` for default one.
     :returns: :class:`Connection` instance.