Skip to content

[TODO] Fix coverage collection for Cython modules #1581

@webknjaz

Description

@webknjaz

Please confirm the following

  • I understand this is open source software provided for free and that I might not receive a timely response.
  • I am positive I am NOT reporting a (potential) security
    vulnerability, to the best of my knowledge. (These must be shared by
    submitting this report form instead, if
    any hesitation exists.)
  • I am willing to submit a pull request with reporoducers as xfailing test cases or even entire fix. (Assign this issue to me.)

Describe the bug

Some time between https://app.codecov.io/gh/aio-libs/yarl/commit/d1286dbe71ea1caaf7c8e488b608ae1637702e90 (d1286db) and https://app.codecov.io/gh/aio-libs/yarl/commit/63c446174218bdcd31274b4488e513de1a05c54e (63c4461) Codecov forgot about the existance of Cython modules entirely.
Need to bisect that and see what happened.

To Reproduce

🤷‍♂️

Expected behavior

*.pyx files should show coverage.

Additional context

The same thing is happening in another project with identical setup: ansible/pylibssh#781.

The only thing suspicious in the diff is the changes to the linetrace setting: d1286db...63c4461. However, ansible-pylibssh still has this setting on and has this problem nevertheless. So I think this might be unreleated.

My guess is that perhaps Cython was unpinned at the time and we didn't notice when this changed.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions