-
-
Notifications
You must be signed in to change notification settings - Fork 175
Explicitly notify Codecov about upload completion #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly notify Codecov about upload completion #1577
Conversation
This patch add an additional invocation of Codecov CLI that tells the backend that we're done uploading. It is supposed to stop Codecov from guessing whether to wait for more uploads for the CI or start processing them already. Upstream refs: * https://docs.codecov.com/docs/cli-options#send-notifications * https://docs.codecov.com/docs/notifications#preventing-notifications-until-youre-ready-to-send-notifications * https://docs.codecov.com/docs/codecovyml-reference#codecovnotifymanual_trigger * codecov/codecov-cli#195 (getsentry/prevent-cli@d634ebd) * codecov/codecov-action#1436 * codecov/engineering-team#107 * codecov/roadmap#20 * codecov/feedback#204 (comment) * codecov/engineering-team#1245 * codecov/engineering-team#3 * codecov/worker#14 (codecov/umbrella@71626b6)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR configures the CI pipeline to explicitly notify Codecov when all coverage uploads are complete, eliminating the need for Codecov to guess when processing should begin.
- Adds a new
coverage-summaryjob that sends completion notifications to Codecov - Updates Codecov configuration to use manual trigger mode instead of counting builds
- Adds actionlint configuration to ignore a known issue with the codecov action
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CHANGES/1577.packaging.rst | Documents the CI enhancement for Codecov notification |
| .github/workflows/ci-cd.yml | Adds coverage-summary job to notify Codecov of upload completion |
| .github/actionlint.yml | Configures actionlint to ignore codecov action input validation |
| .codecov.yml | Switches from build counting to manual trigger mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Performance ReportMerging #1577 will not alter performanceComparing Summary
|
|
Should it work within this PR? Seems there's no notification.. |
|
I imagine Codecov might be waiting to process the reports before posting. Let's observe in the near future.. Also, check statuses also count as notifications, I think. |
|
Pretty sure it's already finished, I can't see any signs that it's processing still. Usually only takes a few seconds anyway. |
|
Maybe I should've kept |
This patch add an additional invocation of Codecov CLI that tells the backend that we're done uploading. It is supposed to stop Codecov from guessing whether to wait for more uploads for the CI or start processing them already.
Upstream refs:
after_n_buildsearlier in the report processing cycle. codecov/engineering-team#1245What do these changes do?
SSIA.
Are there changes in behavior for the user?
Nope.
Related issue number
N/A
Checklist