Skip to content

Conversation

@webknjaz
Copy link
Member

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR configures the CI pipeline to explicitly notify Codecov when all coverage uploads are complete, eliminating the need for Codecov to guess when processing should begin.

  • Adds a new coverage-summary job that sends completion notifications to Codecov
  • Updates Codecov configuration to use manual trigger mode instead of counting builds
  • Adds actionlint configuration to ignore a known issue with the codecov action

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
CHANGES/1577.packaging.rst Documents the CI enhancement for Codecov notification
.github/workflows/ci-cd.yml Adds coverage-summary job to notify Codecov of upload completion
.github/actionlint.yml Configures actionlint to ignore codecov action input validation
.codecov.yml Switches from build counting to manual trigger mode

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@webknjaz webknjaz enabled auto-merge (squash) October 10, 2025 23:34
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 10, 2025

CodSpeed Performance Report

Merging #1577 will not alter performance

Comparing webknjaz:maintenance/codecov-send-notifications (00ec6a0) with master (c3d4570)

Summary

✅ 101 untouched

@webknjaz webknjaz merged commit 1bd3f3e into aio-libs:master Oct 10, 2025
62 of 64 checks passed
@Dreamsorcerer
Copy link
Member

Should it work within this PR? Seems there's no notification..

@webknjaz
Copy link
Member Author

I imagine Codecov might be waiting to process the reports before posting. Let's observe in the near future.. Also, check statuses also count as notifications, I think.

@Dreamsorcerer
Copy link
Member

Pretty sure it's already finished, I can't see any signs that it's processing still. Usually only takes a few seconds anyway.

@webknjaz
Copy link
Member Author

Maybe I should've kept wait_for_ci: false..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants