Skip to content

Commit c03b1b9

Browse files
authored
IMM review (#113)
Since the last review, Insights and Deployment have been made optional, and we opt out of each now. The highly performance-sensitive nature of this library means that adding telemetry would incur unacceptable overheads; applications using this library would typically collect any performance telemetry at a higher level. And this is a leaf component that is never deployed in isolation, and which has no deployment requirements of its own, so there is nothing to do on that front. In this review, we therefore now opt out of both rules.
1 parent 224c041 commit c03b1b9

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,4 @@ The IMM is endjin's IP quality framework.
110110

111111
[![Production Use](https://endimmfuncdev.azurewebsites.net/api/imm/github/ais-dotnet/Ais.Net/rule/87ee2c3e-b17a-4939-b969-2c9c034d05d7?cache=false)](https://endimmfuncdev.azurewebsites.net/api/imm/github/ais-dotnet/Ais.Net/rule/87ee2c3e-b17a-4939-b969-2c9c034d05d7?cache=false)
112112

113-
[![Insights](https://endimmfuncdev.azurewebsites.net/api/imm/github/ais-dotnet/Ais.Net/rule/71a02488-2dc9-4d25-94fa-8c2346169f8b?cache=false)](https://endimmfuncdev.azurewebsites.net/api/imm/github/ais-dotnet/Ais.Net/rule/71a02488-2dc9-4d25-94fa-8c2346169f8b?cache=false)
114-
115113
[![Packaging](https://endimmfuncdev.azurewebsites.net/api/imm/github/ais-dotnet/Ais.Net/rule/547fd9f5-9caf-449f-82d9-4fba9e7ce13a?cache=false)](https://endimmfuncdev.azurewebsites.net/api/imm/github/ais-dotnet/Ais.Net/rule/547fd9f5-9caf-449f-82d9-4fba9e7ce13a?cache=false)
116-
117-
[![Deployment](https://endimmfuncdev.azurewebsites.net/api/imm/github/ais-dotnet/Ais.Net/rule/edea4593-d2dd-485b-bc1b-aaaf18f098f9?cache=false)](https://endimmfuncdev.azurewebsites.net/api/imm/github/ais-dotnet/Ais.Net/rule/edea4593-d2dd-485b-bc1b-aaaf18f098f9?cache=false)

imm.yaml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
Id: da4ed776-0365-4d8a-a297-c4e91a14d646
6363
Measures:
6464
-
65-
Date: 2020-01-21
65+
Date: 2021-02-03
6666
-
6767
Name: 'Framework Version'
6868
Id: 6c0402b3-f0e3-4bd7-83fe-04bb6dca7924
@@ -106,10 +106,7 @@
106106
-
107107
Name: Insights
108108
Id: 71a02488-2dc9-4d25-94fa-8c2346169f8b
109-
Measures:
110-
-
111-
Score: 0
112-
Description: None
109+
OptOut: true
113110
-
114111
Name: Packaging
115112
Id: 547fd9f5-9caf-449f-82d9-4fba9e7ce13a
@@ -126,7 +123,4 @@
126123
-
127124
Name: Deployment
128125
Id: edea4593-d2dd-485b-bc1b-aaaf18f098f9
129-
Measures:
130-
-
131-
Score: 0
132-
Description: None
126+
OptOut: true

0 commit comments

Comments
 (0)