Compatibility with github-markdown-css

[brunowego]

This project is really cool and I think a use with github-markdown-css will be nicer.

[rabidaudio]

+1

May send a PR for this in the future

[sankethkatta]

👍 Would love this as well

[qiutiaoming]

+1

[belyan]

+1

[ckreon]

Why isn't it compatible at the moment? Shouldn't you be able to point to the github-markdown css file with the options.cssPath?

options.cssPath

Type: String
Default value: [module path]/markdown-pdf/css/pdf.css

Path to custom CSS file, relative to the current directory.

Edit: I see the issue, you have to change the properties. I'll make a PR.

[ckreon]

I made a pull-request to address this - #91.

[brunowego]

Thanks @ckreon

[marcosdiasdev]

@ckreon I got your PR modifications and added the options object like in your README.md but it's still not being styled.

[ckreon]

@timarcosdias Can you show your config/script?

[marcosdiasdev]

@ckreon I added pdf_ghm.css to my markdown-pdf installation and my code looks like:

var options = {
  cssPath: 'C:/Users/Marcos/node_modules/markdown-pdf/css/pdf_ghm.css'
}

markdownpdf(options)
  .concat
  .from(mdDocs)
  .to(bookPath, function () {
    console.log("Created", bookPath)
  })

I get no different result without the options object.

[ckreon]

@timarcosdias Try grabbing just the CSS file from my PR - and save it to your local drive. Use the current official release of MarkdownPDF and just use the options to point to that custom CSS file.

Here's part of my script file for you to reference, my CSS file is named _pdf_style.css:

var ops = {
  cssPath: '_assets/css/_pdf_style.css',
  remarkable: {
    xhtmlOut: true,
    linkify: true
  }
}

I use a relative path, as you can see, as opposed to an absolute path like you defined, though that shouldn't cause any issues as long as you are running it from your local environment.

[marcosdiasdev]

@ckreon It still doesn't work. I worked it out with Gitbook + Calibre. I recommend it! Anyway, thank you for the support.