Skip to content

Commit 4334c40

Browse files
authored
Merge pull request #7092 from alibaba/fix/weex-appear-cb
fix: fix appear event handler callback refs in WeexAppear component
2 parents b719564 + fb013fd commit 4334c40

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

.changeset/fast-falcons-serve.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@ice/appear': patch
3+
---
4+
5+
fix appear event handler callback refs in WeexAppear component

packages/appear/src/weex/index.tsx

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,28 @@ const WeexAppear = forwardRef<any, AppearProps>((props, ref) => {
1212
// Use copy of childrenRef to avoid ref value changed in cleanup phase.
1313
const nodeRef = typeof childrenRef === 'object' ? childrenRef.current : null;
1414

15+
const appearHandler = (e: CustomEvent) => {
16+
onAppear?.(e);
17+
};
1518
// Return early if onAppear callback not specified.
16-
onAppear && nodeRef?.addEventListener('appear', (e: CustomEvent) => onAppear(e));
19+
onAppear && nodeRef?.addEventListener('appear', appearHandler);
1720

1821
return () => {
19-
onAppear && nodeRef?.removeEventListener('appear', (e: CustomEvent) => onAppear(e));
22+
onAppear && nodeRef?.removeEventListener('appear', appearHandler);
2023
};
2124
}, [childrenRef, onAppear]);
2225

2326
useEffect(() => {
2427
const nodeRef = typeof childrenRef === 'object' ? childrenRef.current : null;
2528

26-
onDisappear && nodeRef?.addEventListener('disappear', (e: CustomEvent) => onDisappear(e));
29+
const disappearHandler = (e: CustomEvent) => {
30+
onDisappear?.(e);
31+
};
32+
33+
onDisappear && nodeRef?.addEventListener('disappear', disappearHandler);
2734

2835
return () => {
29-
onDisappear && nodeRef?.removeEventListener('disappear', (e: CustomEvent) => onDisappear(e));
36+
onDisappear && nodeRef?.removeEventListener('disappear', disappearHandler);
3037
};
3138
}, [childrenRef, onDisappear]);
3239

0 commit comments

Comments
 (0)