Fixes DataType STRING.BINARY

Author: bravo-kernel

lib/type-mapper.js

@@ -240,9 +240,10 @@ class TypeMapper {
       // ----------------------------------------------------------------------
       case 'STRING': {
         result = { ...STRING };
-        let length = properties.type.options && properties.type.options.length;
 
         // use available length aliases if length property matches
+        let length = properties.type.options && properties.type.options.length;
+
         length = STRING_LENGTHS[length] || length;
         if (length) result.maxLength = length;
 

test/models/user.js

@@ -82,7 +82,7 @@ module.exports = sequelize => {
   }
 
   if (supportedDataType('UUIDV4')) {
-    Model.rawAttributes.STRING_DOT_BINARY = {
+    Model.rawAttributes.UUIDV4 = {
       type: DataTypes.UUID,
     };
   }

test/strategies/json-schema-v7-strategy.test.js

@@ -66,6 +66,16 @@ describe('JsonSchema7Strategy', function() {
           });
         });
 
+        describe('STRING_DOT_BINARY', function() {
+          it("has property 'type' of type 'string'", function() {
+            expect(schema.properties.STRING_DOT_BINARY.type).toEqual('string');
+          });
+
+          it("has property 'format' of type 'binary'", function() {
+            expect(schema.properties.STRING_DOT_BINARY.format).toEqual('binary');
+          });
+        });
+
         describe('STRING_ALLOWNULL', function() {
           it("has property 'type' of type 'array'", function() {
             expect(Array.isArray(schema.properties.STRING_ALLOWNULL.type)).toBe(true);

test/strategies/openapi-v3-stragegy.test.js

@@ -60,13 +60,22 @@ describe('OpenApi3Strategy', function() {
           });
         });
 
+        describe('STRING_DOT_BINARY', function() {
+          it("has property 'type' of type 'string'", function() {
+            expect(userSchema.properties.STRING_DOT_BINARY.type).toEqual('string');
+          });
+
+          it("has property 'format' of type 'binary'", function() {
+            expect(userSchema.properties.STRING_DOT_BINARY.format).toEqual('binary');
+          });
+        });
+
         describe('STRING_ALLOWNULL', function() {
           it("has property 'type' of type 'string'", function() {
             expect(userSchema.properties.STRING_ALLOWNULL.type).toEqual('string');
           });
 
           it("has property 'nullable' of type 'boolean'", function() {
-            expect(userSchema.properties.STRING_ALLOWNULL).toHaveProperty('nullable');
             expect(typeof userSchema.properties.STRING_ALLOWNULL.nullable).toEqual('boolean');
           });
         });