Skip to content

Commit c71d171

Browse files
marcus-n3rdanandanand84
authored andcommitted
Hammer, Hanging Man, and Shooting Star Corrections (#145)
* Added hammer, hanging man, and shooting star patterns to bearish and bullish indicators. Bearish: - Bearish Hammer - Bearish Inverted Hammer - Hanging Man - Hanging Man (Unconfirmed) - Shooting Star - Shooting Star (Unconfirmed) Bullish: - Bullish Hammer - Bullish Inverted Hammer - Hammer Pattern - Hammer Pattern (Unconfirmed) * Added hammer, hanging man, and shooting star patterns to src/index.ts * Ran build scripts. * Updated README.md regarding new indicators.
1 parent 57dc45d commit c71d171

File tree

15 files changed

+540
-35
lines changed

15 files changed

+540
-35
lines changed

README.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -306,14 +306,15 @@ npm test
306306
npm run cover
307307
```
308308
309-
## Adding new indicators.
310-
311-
1. Add tests for the indicator. Make it pass. It would be better if a sample of the stockcharts excel is used for the test case.
312-
1. Add the indicator to the index.js
313-
1. Run `npm run build` so it adds the indicator to the browser.js
314-
1. Add it to read me, with the link to the tonicdev url containing the sample.
315-
1. Add indicator it to keywords in package.json and bower.json
316-
1. Send a pull request.
309+
## Adding new indicators
310+
311+
1. Add tests for the indicator and make them pass.
312+
(It would be better if a sample of the stockcharts excel is used for the test case.)
313+
1. Add the indicator to the `index.js` and `src/index.ts`
314+
1. Run build scripts: `npm run build-lib && npm run generateDts && npm run start`
315+
1. Add it to `README.md`, with the link to the runkit url containing the sample.
316+
1. Add indicator it to keywords in `package.json` and `bower.json`
317+
1. Send a Pull Request.
317318
318319
319320
## Verify Documentation

declarations/generated.d.ts

Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -714,6 +714,75 @@ export class ThreeWhiteSoldiers extends CandlestickFinder {
714714
}
715715
export function threewhitesoldiers(data: StockData): any;
716716

717+
export class BullishHammerStick extends CandlestickFinder {
718+
constructor();
719+
logic(data: StockData): boolean;
720+
}
721+
export function bullishhammerstick(data: StockData): any;
722+
723+
export class BearishHammerStick extends CandlestickFinder {
724+
constructor();
725+
logic(data: StockData): boolean;
726+
}
727+
export function bearishhammerstick(data: StockData): any;
728+
729+
export class BullishInvertedHammerStick extends CandlestickFinder {
730+
constructor();
731+
logic(data: StockData): boolean;
732+
}
733+
export function bullishinvertedhammerstick(data: StockData): any;
734+
735+
export class BearishInvertedHammerStick extends CandlestickFinder {
736+
constructor();
737+
logic(data: StockData): boolean;
738+
}
739+
export function bearishinvertedhammerstick(data: StockData): any;
740+
741+
export class HammerPattern extends CandlestickFinder {
742+
constructor();
743+
logic(data: StockData): boolean;
744+
downwardTrend(data: StockData, confirm?: boolean): boolean;
745+
includesHammer(data: StockData, confirm?: boolean): any;
746+
hasConfirmation(data: StockData): boolean;
747+
}
748+
export function hammerpattern(data: StockData): any;
749+
750+
export class HammerPatternUnconfirmed extends HammerPattern {
751+
constructor();
752+
logic(data: StockData): boolean;
753+
}
754+
export function hammerpatternunconfirmed(data: StockData): any;
755+
756+
export class HangingMan extends CandlestickFinder {
757+
constructor();
758+
logic(data: StockData): boolean;
759+
upwardTrend(data: StockData, confirm?: boolean): boolean;
760+
includesHammer(data: StockData, confirm?: boolean): any;
761+
hasConfirmation(data: StockData): boolean;
762+
}
763+
export function hangingman(data: StockData): any;
764+
765+
export class HangingManUnconfirmed extends HangingMan {
766+
constructor();
767+
logic(data: StockData): boolean;
768+
}
769+
export function hangingmanunconfirmed(data: StockData): any;
770+
771+
export class ShootingStar extends CandlestickFinder {
772+
constructor();
773+
logic(data: StockData): boolean;
774+
upwardTrend(data: StockData, confirm?: boolean): boolean;
775+
includesHammer(data: StockData, confirm?: boolean): any;
776+
hasConfirmation(data: StockData): boolean;
777+
}
778+
export function shootingstar(data: StockData): any;
779+
780+
export class ShootingStarUnconfirmed extends ShootingStar {
781+
constructor();
782+
logic(data: StockData): boolean;
783+
}
784+
export function shootingstarunconfirmed(data: StockData): any;
785+
717786
/**
718787
* Calcaultes the fibonacci retracements for given start and end points
719788
*

declarations/index.d.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,16 @@ export { bullishspinningtop } from './candlestick/BullishSpinningTop';
5959
export { bearishspinningtop } from './candlestick/BearishSpinningTop';
6060
export { threeblackcrows } from './candlestick/ThreeBlackCrows';
6161
export { threewhitesoldiers } from './candlestick/ThreeWhiteSoldiers';
62+
export { bullishhammerstick } from './candlestick/BullishHammerStick';
63+
export { bearishhammerstick } from './candlestick/BearishHammerStick';
64+
export { bullishinvertedhammerstick } from './candlestick/BullishInvertedHammerStick';
65+
export { bearishinvertedhammerstick } from './candlestick/BearishInvertedHammerStick';
66+
export { hammerpattern } from './candlestick/HammerPattern';
67+
export { hammerpatternunconfirmed } from './candlestick/HammerPatternUnconfirmed';
68+
export { hangingman } from './candlestick/HangingMan';
69+
export { hangingmanunconfirmed } from './candlestick/HangingManUnconfirmed';
70+
export { shootingstar } from './candlestick/ShootingStar';
71+
export { shootingstarunconfirmed } from './candlestick/ShootingStarUnconfirmed';
6272
export { fibonacciretracement } from './drawingtools/fibonacci';
6373
export { predictPattern, PatternDetector } from './patterndetection/patterndetection';
6474
export { AvailablePatterns } from './patterndetection/patterndetection';

dist/browser.es6.js

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/browser.es6.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/browser.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/browser.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)