Remove toast notifications and simplify dashboard UI

Author: andrewm4894

dashboard/components.py

@@ -207,12 +207,22 @@ def create_batch_card(batch_name: str, stats: dict) -> Card:
     return Card(
         DivLAligned(
             Div(
-                H4(batch_name, cls="mb-2"),
+                Button(
+                    batch_name,
+                    hx_get=f"/batch/{batch_name}",
+                    hx_push_url=f"/batch/{batch_name}",
+                    hx_target="#main-content",
+                    hx_indicator="#loading",
+                    cls=ButtonT.primary,
+                ),
                 DivLAligned(
                     Div(
                         DivLAligned(
                             UkIcon("activity", cls="text-blue-500"),
-                            P(f"{stats['unique_metrics']} metrics", cls=TextPresets.muted_sm),
+                            P(
+                                f"{stats['unique_metrics']} metrics",
+                                cls=TextPresets.muted_sm,
+                            ),
                             cls="space-x-2",
                         ),
                         DivLAligned(
@@ -222,30 +232,28 @@ def create_batch_card(batch_name: str, stats: dict) -> Card:
                         ),
                         DivLAligned(
                             UkIcon("bar-chart", cls="text-purple-500"),
-                            P(f"Avg Score: {stats['avg_score']:.1%}", cls=TextPresets.muted_sm),
+                            P(
+                                f"Avg Score: {stats['avg_score']:.1%}",
+                                cls=TextPresets.muted_sm,
+                            ),
                             cls="space-x-2",
                         ),
                         DivLAligned(
                             UkIcon("alert-circle", cls="text-red-500"),
-                            P(f"{stats['alert_count']} alerts", cls=TextPresets.muted_sm),
+                            P(
+                                f"{stats['alert_count']} alerts",
+                                cls=TextPresets.muted_sm,
+                            ),
                             cls="space-x-2",
                         ),
-                        cls="space-y-2",
+                        cls="space-y-1",
                     )
                 ),
             ),
-            Button(
-                "View Metrics",
-                hx_get=f"/batch/{batch_name}",
-                hx_push_url=f"/batch/{batch_name}",
-                hx_target="#main-content",
-                hx_indicator="#loading",
-                cls=ButtonT.primary,
-            ),
             style="justify-content: space-between;",
             cls="flex-row items-center",
         ),
-        cls="p-6 hover:border-primary transition-colors duration-200",
+        cls="p-2 hover:border-primary transition-colors duration-200",
     )
 
 

dashboard/routes.py

@@ -24,27 +24,21 @@ def post(request: Request):
     """
     Refresh all batch data.
     """
-    # Add loading toast
-    loading_toast = add_toast("Refreshing all batch data...", "info")
-    
+
     try:
         # Clear all batch caches
         app.state.df_cache.clear()
         app.state.stats_cache.clear()
         app.state.chart_cache.clear()
-        
+
         # Get the updated content
         response = index(request)
-        
-        # Add success toast
-        success_toast = add_toast("Successfully refreshed all batch data", "success")
-        
-        return [loading_toast, response, success_toast]
-        
+
+        return [response]
+
     except Exception as e:
-        # Add error toast
-        error_toast = add_toast(f"Error refreshing batch data: {str(e)}", "error")
-        return [loading_toast, error_toast]
+        log.error(f"Error refreshing all batch data: {e}")
+        return []
 
 
 @rt
@@ -64,41 +58,21 @@ def index(request: Request):
     """
     )
 
-    # Add toast container for notifications
-    toast_container = Div(id="toast-container", cls=(ToastHT.end, ToastVT.top))
-
     # Calculate batch stats
     batch_stats = {}
     for batch_name in app.state.metric_batches:
         if batch_name not in app.state.df_cache:
             try:
-                # Add loading toast
-                loading_toast = Toast(
-                    f"Loading data for batch {batch_name}...", 
-                    alert_cls=AlertT.info,
-                    cls=(ToastHT.end, ToastVT.top)
-                )
-                
+
                 df = get_data(
                     app.state.specs_enabled[batch_name], max_n=DEFAULT_ALERT_MAX_N
                 )
-                
-                # Add success toast
-                success_toast = Toast(
-                    f"Successfully loaded data for {batch_name}", 
-                    alert_cls=AlertT.success,
-                    cls=(ToastHT.end, ToastVT.top)
-                )
-                
+
             except Exception as e:
                 log.error(f"Error getting data for batch {batch_name}: {e}")
-                # Add error toast
-                error_toast = Toast(
-                    f"Error loading data for {batch_name}: {str(e)}", 
-                    alert_cls=AlertT.error,
-                    cls=(ToastHT.end, ToastVT.top)
+                df = pd.DataFrame(
+                    data=[], columns=["metric_name", "metric_timestamp", "metric_value"]
                 )
-                df = pd.DataFrame(data=[], columns=['metric_name', 'metric_timestamp', 'metric_value'])
             app.state.df_cache[batch_name] = df
         else:
             df = app.state.df_cache[batch_name]
@@ -117,8 +91,8 @@ def index(request: Request):
         filtered_batches.keys(),
         key=lambda x: (
             -filtered_batches[x]["alert_count"],  # Negative for descending order
-            -filtered_batches[x]["avg_score"]     # Negative for descending order
-        )
+            -filtered_batches[x]["avg_score"],  # Negative for descending order
+        ),
     )
 
     main_content = Div(
@@ -127,25 +101,22 @@ def index(request: Request):
                 H2("Anomstack", cls="text-2xl font-bold pl-2"),
                 DivLAligned(
                     Button(
-                        DivLAligned(
-                            UkIcon("refresh-ccw"),
-                            cls="space-x-2"
-                        ),
+                        DivLAligned(UkIcon("refresh-ccw"), cls="space-x-2"),
                         cls=ButtonT.ghost,  # Using ghost style to match header aesthetics
                         hx_post="/refresh-all",
                         hx_target="#main-content",
                         hx_indicator="#loading",
-                        uk_tooltip="Refresh all"
+                        uk_tooltip="Refresh all",
                     ),
                     A(
                         UkIcon("github"),
                         href="https://github.com/andrewm4894/anomstack",
                         cls=ButtonT.ghost,
-                        uk_tooltip="View the source code on GitHub"
+                        uk_tooltip="View the source code on GitHub",
                     ),
-                    cls="space-x-2"
+                    cls="space-x-2",
                 ),
-                cls="flex justify-between items-center mb-6"
+                cls="flex justify-between items-center mb-6",
             ),
             # Show warning if no metric batches
             (
@@ -156,18 +127,21 @@ def index(request: Request):
                             "No metric batches found. Is Dagster running?",
                             cls=TextPresets.muted_sm,
                         ),
-                        cls="space-x-2 p-4 bg-yellow-50 text-yellow-700 rounded-md",
+                        cls="space-x-2 p-2 bg-yellow-50 text-yellow-700 rounded-md",
                     ),
                     cls="mb-6",
                 )
                 if not app.state.metric_batches
                 else Grid(
-                    *[create_batch_card(name, batch_stats[name]) for name in sorted_batch_names],
-                    cols=3,
-                    gap=4,
+                    *[
+                        create_batch_card(name, batch_stats[name])
+                        for name in sorted_batch_names
+                    ],
+                    cols=4,
+                    gap=2,
                 )
             ),
-            cls="p-6",
+            cls="p-2",
         ),
         id="main-content",
     )
@@ -176,11 +150,10 @@ def index(request: Request):
     if is_htmx:
         return main_content
 
-    # For full page loads, return the complete layout with toast container
+    # For full page loads, return the complete layout
     return (
         Title("Anomstack"),
         script,
-        toast_container,  # Add toast container
         Div(
             Safe('<span class="htmx-indicator">Loading...</span>'),
             id="loading",
@@ -304,23 +277,18 @@ def get(batch_name: str, session):
     """
     Refresh the batch view for a given batch name.
     """
-    # Add loading toast
-    loading_toast = add_toast(f"Refreshing data for {batch_name}...", "info")
-    
+
     try:
         app.state.clear_batch_cache(batch_name)
-        response = get_batch_view(batch_name, session, initial_load=DEFAULT_LOAD_N_CHARTS)
-        
-        # Add success toast
-        success_toast = add_toast(f"Successfully refreshed {batch_name}", "success")
-        
-        # Return both the response and the toasts
-        return [loading_toast, response, success_toast]
-        
+        response = get_batch_view(
+            batch_name, session, initial_load=DEFAULT_LOAD_N_CHARTS
+        )
+
+        # Return the response
+        return [response]
+
     except Exception as e:
-        # Add error toast
-        error_toast = add_toast(f"Error refreshing {batch_name}: {str(e)}", "error")
-        return [loading_toast, error_toast]
+        return []
 
 
 @rt("/batch/{batch_name}/load-more/{start_index}")
@@ -483,39 +451,9 @@ def post(batch_name: str, session=None):
     """
     Toggle between narrow (1px) and normal (2px) line width.
     """
-    app.state.narrow_lines = not getattr(app.state, 'narrow_lines', False)
+    app.state.narrow_lines = not getattr(app.state, "narrow_lines", False)
     app.state.line_width = 1 if app.state.narrow_lines else 2
     app.state.chart_cache.clear()  # Clear cache to regenerate charts
     return get_batch_view(
         batch_name, session=session, initial_load=DEFAULT_LOAD_N_CHARTS
     )
-
-
-# Add helper function to create toast messages for other routes
-def add_toast(message: str, type: str = "info") -> Toast:
-    """Create a toast notification"""
-    alert_types = {
-        "info": AlertT.info,
-        "success": AlertT.success,
-        "warning": AlertT.warning,
-        "error": AlertT.error
-    }
-    return Toast(
-        message,
-        alert_cls=alert_types.get(type, AlertT.info),
-        cls=(ToastHT.end, ToastVT.top),
-        hx_swap_oob="beforeend",
-        hx_target="#toast-container"
-    )
-
-
-# Add new test toast route
-@rt("/test-toast")
-def post(request: Request):
-    """Test route to trigger different types of toasts."""
-    return [
-        add_toast("This is an info toast", "info"),
-        add_toast("This is a success toast", "success"),
-        add_toast("This is a warning toast", "warning"),
-        add_toast("This is an error toast", "error")
-    ]