fix the search functionality

Author: andrewm4894

dashboard/components.py

@@ -164,18 +164,27 @@ def _create_search_form(batch_name):
     """
     Create the search form for the dashboard.
     """
+    state = get_state()
+    current_search = state.search_term.get(batch_name, "")
+    
     return Form(
         Input(
-            type="text",
+            type="search",
             name="search",
             placeholder="Search metrics...",
+            value=current_search,
             cls="uk-input uk-form-small",
             style="width: 200px;",
             uk_tooltip="Filter metrics by name",
+            autocomplete="off",
+            aria_label="Search metrics",
         ),
-        hx_post=f"/batch/{batch_name}/search",
+        hx_get=f"/batch/{batch_name}/search",
         hx_target="#charts-container",
-        hx_trigger="keyup changed delay:500ms, search",
+        hx_trigger="input changed delay:300ms, search",
+        hx_indicator="#loading",
+        hx_swap="outerHTML",
+        onsubmit="return false;",
     )
 
 

dashboard/routes.py

@@ -343,32 +343,55 @@ def get(batch_name: str, start_index: int):
 
 
 @rt("/batch/{batch_name}/search")
-def post(batch_name: str, search: str = ""):
+def get(batch_name: str, search: str = ""):
     """
     Search for a given batch name and search string.
     """
     import re
 
+    # Store the search term in state
+    app.state.search_term[batch_name] = search
+
+    # Ensure we have stats for this batch
+    if batch_name not in app.state.stats_cache:
+        app.state.calculate_metric_stats(batch_name)
+    
     metric_stats = app.state.stats_cache[batch_name]
     try:
         pattern = re.compile(search, re.IGNORECASE) if search else None
-        filtered_stats = [
-            stat
-            for stat in metric_stats
+        
+        # Keep track of original indices while filtering
+        filtered_stats_with_indices = [
+            (i, stat)  # Keep original index with the stat
+            for i, stat in enumerate(metric_stats)
             if not pattern or pattern.search(stat["metric_name"])
         ]
-        placeholders = []
-        for i, stat in enumerate(filtered_stats):
-            placeholders.append(
+        
+        # Return empty state if no results
+        if not filtered_stats_with_indices:
+            return Div(
+                P("No matching metrics found", cls="text-muted-foreground p-4 text-center"),
+                id="charts-grid",
+            )
+        
+        # Create chart placeholders using original indices
+        return Div(
+            *[
                 ChartManager.create_chart_placeholder(
-                    stat["metric_name"], i, batch_name
+                    stat["metric_name"], 
+                    original_index,  # Use the original index instead of enumeration
+                    batch_name
                 )
-            )
-        return (
-            Div(*placeholders) if placeholders else Div(P("No matching metrics found"))
+                for original_index, stat in filtered_stats_with_indices
+            ],
+            id="charts-grid",
+            cls=f"grid grid-cols-{2 if app.state.two_columns else 1} gap-4"
         )
     except re.error:
-        return Div(P("Invalid search pattern"))
+        return Div(
+            P("Invalid search pattern", cls="text-red-500 p-4 text-center"),
+            id="charts-grid",
+        )
 
 
 @rt("/batch/{batch_name}/update-n")

dashboard/state.py

@@ -35,6 +35,7 @@ def __init__(self):
         self.alert_max_n = {}
         self.line_width = 2
         self.show_legend = False
+        self.search_term = {}
 
     def clear_batch_cache(self, batch_name):
         """