Merge pull request #103 from andrewm4894/small-plotting-improvements

Small plotting improvements

Author: andrewm4894

anomstack/jobs/plot.py

@@ -24,7 +24,9 @@
 from anomstack.plots.plot import make_batch_plot
 from anomstack.sql.read import read_sql
 
-ANOMSTACK_MAX_RUNTIME_SECONDS_TAG = os.getenv("ANOMSTACK_MAX_RUNTIME_SECONDS_TAG", 3600)
+ANOMSTACK_MAX_RUNTIME_SECONDS_TAG = os.getenv(
+    "ANOMSTACK_MAX_RUNTIME_SECONDS_TAG", 3600
+)
 
 
 def build_plot_job(spec: dict) -> JobDefinition:
@@ -37,7 +39,6 @@ def build_plot_job(spec: dict) -> JobDefinition:
         JobDefinition: The plot job definition.
     """
 
-
     if spec.get("disable_plot"):
 
         @job(

anomstack/plots/plot.py

@@ -2,10 +2,12 @@
 Some helper functions for plotting.
 """
 
+import matplotlib.dates as mdates
 import matplotlib.pyplot as plt
 import pandas as pd
 import seaborn as sns
 from matplotlib.figure import Figure
+from matplotlib.ticker import MaxNLocator
 
 
 def make_alert_plot(
@@ -101,6 +103,7 @@ def make_batch_plot(df: pd.DataFrame) -> plt.Figure:
     Returns:
         plt.Figure: The generated batch plot figure.
     """
+    df['metric_timestamp'] = pd.to_datetime(df['metric_timestamp'])
     unique_metrics = df["metric_name"].unique()
     colors = sns.color_palette("viridis", len(unique_metrics))
 
@@ -123,11 +126,14 @@ def make_batch_plot(df: pd.DataFrame) -> plt.Figure:
             label="Metric Value",
             color=colors[i],
             ax=ax1,
-            legend=True,
+            legend=False,
         )
         ax1.set_ylabel("Metric Value")
         ax1.tick_params(axis="y", labelcolor=colors[i])
 
+        ax1.xaxis.set_major_locator(MaxNLocator(nbins=5))
+        ax1.xaxis.set_major_formatter(mdates.DateFormatter("%Y-%m-%d %H:%M"))
+
         ax2 = ax1.twinx()
         sns.lineplot(
             data=metric_data,