port default queries to duckdb

Author: andrewm4894

metrics/defaults/sql/alerts.sql

@@ -1,13 +1,14 @@
 /*
 Template for generating the input data for the alert job.
 
-Written for SQLite but will be translated to target dialect based on `db` param via sqlglot.
+Written for DuckDB but will be translated to target dialect based on `db` param via sqlglot.
 */
 
 with
 
 -- Filter the data to the relevant metric batch for metrics
-metric_value_data as (
+metric_value_data as 
+(
 select
   metric_timestamp,
   metric_batch,
@@ -17,20 +18,17 @@ from
   {{ table_key }}
 where
   metric_batch = '{{ metric_batch }}'
-  and
-  metric_type = 'metric'
-  and
-  metric_timestamp >= date('now', '-{{ alert_metric_timestamp_max_days_ago }} day')
+  and metric_type = 'metric'
+  and metric_timestamp >= current_date - interval '{{ alert_metric_timestamp_max_days_ago }} day'
   {% if alert_exclude_metrics is defined %}
-  and
-  -- Exclude the specified metrics
-  metric_name not in ({{ ','.join(alert_exclude_metrics) }})
+  and metric_name not in ({{ ','.join(alert_exclude_metrics) }})
   {% endif %}
 group by metric_timestamp, metric_batch, metric_name
 ),
 
 -- Filter the data to the relevant metric batch for scores
-metric_score_data as (
+metric_score_data as 
+(
 select
   metric_timestamp,
   metric_batch,
@@ -40,15 +38,14 @@ from
   {{ table_key }}
 where
   metric_batch = '{{ metric_batch }}'
-  and
-  metric_type = 'score'
-  and
-  metric_timestamp >= date('now', '-{{ alert_metric_timestamp_max_days_ago }} day')
+  and metric_type = 'score'
+  and metric_timestamp >= current_date - interval '{{ alert_metric_timestamp_max_days_ago }} day'
 group by metric_timestamp, metric_batch, metric_name
 ),
 
 -- Filter the data to the relevant metric batch for alerts
-metric_alert_data as (
+metric_alert_data as 
+(
 select
   metric_timestamp,
   metric_batch,
@@ -58,15 +55,14 @@ from
   {{ table_key }}
 where
   metric_batch = '{{ metric_batch }}'
-  and
-  metric_type = 'alert'
-  and
-  metric_timestamp >= date('now', '-{{ alert_metric_timestamp_max_days_ago }} day')
+  and metric_type = 'alert'
+  and metric_timestamp >= current_date - interval '{{ alert_metric_timestamp_max_days_ago }} day'
 group by metric_timestamp, metric_batch, metric_name
 ),
 
 -- Rank the score data by recency
-metric_score_recency_ranked as (
+metric_score_recency_ranked as 
+(
 select
   metric_timestamp,
   metric_batch,
@@ -78,7 +74,8 @@ from
 ),
 
 -- Rank the value data by recency
-metric_value_recency_ranked as (
+metric_value_recency_ranked as 
+(
 select
   metric_timestamp,
   metric_batch,
@@ -97,30 +94,26 @@ select
   m.metric_name,
   m.metric_value,
   s.metric_score,
-  ifnull(a.metric_alert_historic, 0) as metric_alert_historic,
+  coalesce(a.metric_alert_historic, 0) as metric_alert_historic,
   m.metric_value_recency_rank,
   s.metric_score_recency_rank
 from
   metric_value_recency_ranked m
 left join
   metric_score_recency_ranked s
-on
+on 
   m.metric_name = s.metric_name
-  and
-  m.metric_batch = s.metric_batch
-  and
-  m.metric_timestamp = s.metric_timestamp
+  and m.metric_batch = s.metric_batch
+  and m.metric_timestamp = s.metric_timestamp
 left join
   metric_alert_data a
-on
+on 
   m.metric_name = a.metric_name
-  and
-  m.metric_batch = a.metric_batch
-  and
-  m.metric_timestamp = a.metric_timestamp
+  and m.metric_batch = a.metric_batch
+  and m.metric_timestamp = a.metric_timestamp
 ),
 
--- Smooth the data
+-- Smooth the data using window functions
 data_smoothed as (
 select
   metric_timestamp,
@@ -131,20 +124,18 @@ select
   metric_alert_historic,
   metric_value_recency_rank,
   metric_score_recency_rank,
-  -- Smooth the metric score using a custom window
-  (select avg(ds.metric_score)
-    from data_ranked ds
-    where ds.metric_name = dr.metric_name
-    and ds.metric_score_recency_rank between dr.metric_score_recency_rank - {{ alert_smooth_n }} and dr.metric_score_recency_rank
+  avg(metric_score) over (
+    partition by metric_batch, metric_name
+    order by metric_score_recency_rank
+    rows between {{ alert_smooth_n }} preceding and current row
   ) as metric_score_smooth,
-  -- Check for recent alerts
-  (select max(ds.metric_alert_historic)
-    from data_ranked ds
-    where ds.metric_name = dr.metric_name
-    and ds.metric_score_recency_rank between dr.metric_score_recency_rank - {{ alert_snooze_n }} and dr.metric_score_recency_rank - 1
+  max(metric_alert_historic) over (
+    partition by metric_batch, metric_name
+    order by metric_score_recency_rank
+    rows between {{ alert_snooze_n }} preceding and 1 preceding
   ) as metric_has_recent_alert
-from
-  data_ranked dr
+from 
+  data_ranked
 ),
 
 -- Calculate the alerts
@@ -160,22 +151,15 @@ select
   metric_score_smooth,
   metric_has_recent_alert,
   case
-    when
-      metric_score_recency_rank <= {{ alert_recent_n }}
-      and
-      (metric_score_smooth >= {{ alert_threshold }} OR {{ alert_always }} = True)
-      and
-      ifnull(metric_has_recent_alert,0) = 0
+    when metric_score_recency_rank <= {{ alert_recent_n }}
+          and (metric_score_smooth >= {{ alert_threshold }} OR {{ alert_always }} = True)
+          and coalesce(metric_has_recent_alert, 0) = 0
     then 1
     else 0
   end as metric_alert_calculated
-from
-  data_smoothed
-where
-  metric_score_recency_rank <= {{ alert_max_n }}
-  or
-  -- flag for always alerting if set
-  {{ alert_always }} = True
+from data_smoothed
+where metric_score_recency_rank <= {{ alert_max_n }}
+    or {{ alert_always }} = True
 ),
 
 -- Filter the data to the metrics with triggered alerts
@@ -184,8 +168,7 @@ select
   metric_batch,
   metric_name,
   max(metric_alert_calculated) as metric_alert_calculated_tmp
-from
-  data_alerts
+from data_alerts
 group by metric_batch, metric_name
 having max(metric_alert_calculated) = 1 or {{ alert_always }} = True
 )
@@ -198,13 +181,12 @@ select
   metric_value,
   metric_score,
   metric_score_smooth,
-  if(metric_score_recency_rank = 1, metric_alert_calculated, metric_alert_historic) as metric_alert
-from
-  data_alerts
-join
-  metrics_triggered
-on
-  data_alerts.metric_batch = metrics_triggered.metric_batch
-  and
-  data_alerts.metric_name = metrics_triggered.metric_name
+  case
+    when metric_score_recency_rank = 1 then metric_alert_calculated
+    else metric_alert_historic
+  end as metric_alert
+from data_alerts
+join metrics_triggered
+  on data_alerts.metric_batch = metrics_triggered.metric_batch
+     and data_alerts.metric_name = metrics_triggered.metric_name
 ;