Skip to content

Commit 9dff536

Browse files
stefanbinojautofix-ci[bot]binary-koan
authored
fix failing test conversation - should respect auto-assign preference when replying (#1068)
ref #1064 # Related Test <img width="939" height="240" alt="Screenshot 2025-10-15 at 5 54 19 PM" src="https://github.com/user-attachments/assets/a148a87b-66cf-48f9-9003-ede24e16e60b" /> # Problem Previously, we checked for `Auto-Assign on Reply` by locating the `Assign yourself` button. However, it seems that this specific element is always present even when the conversation is already assigned to the user. This change was introduced by devin #1057 ### Video-proof : https://github.com/user-attachments/assets/5ab64d57-2738-4269-97a0-8d0c895f7546 # Solution Instead of checking if `Assign yourself` button is present or not, we check if the assignee is user or not. ### Test passing screen shot <img width="1901" height="1001" alt="Screenshot 2025-10-15 at 4 17 49 PM" src="https://github.com/user-attachments/assets/51eaa6ed-7133-4b52-a29c-cdfb8624f5b6" /> Link to upstream CI action passing all test suites: <img width="649" height="173" alt="Screenshot 2025-10-15 at 5 49 41 PM" src="https://github.com/user-attachments/assets/33fb16d2-0bbd-4c19-a351-608ed650d2e1" /> https://github.com/stefanbinoj/helper/actions/runs/18527904075/job/52802976944 ## AI Usage : No AI was used in the creation of this PR. ## Self Review : I have self reviewed all codes that i have written. --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Jono M <[email protected]>
1 parent f11b95f commit 9dff536

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/e2e/conversations/conversationActions.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ test.describe("Conversation Actions", () => {
317317

318318
await sendReplyMessage(page, "Auto-assign off test reply message");
319319

320-
await expect(page.getByRole("button", { name: "Assign yourself" })).toBeVisible();
320+
await expect(page.getByRole("button", { name: "Unassigned" })).toBeVisible();
321321

322322
await page.goto("/settings/preferences");
323323
await page.locator('[aria-label="Auto-assign on reply Switch"]').click();
@@ -328,7 +328,7 @@ test.describe("Conversation Actions", () => {
328328

329329
await sendReplyMessage(page, "Auto-assign on test reply message");
330330
await expect(page.getByTestId("message-thread")).toContainText("Auto-assign on test reply message");
331-
await expect(page.getByRole("button", { name: "Assign yourself" })).not.toBeVisible();
331+
await expect(page.getByRole("button", { name: "[email protected]" })).toBeVisible();
332332
});
333333
});
334334
});

0 commit comments

Comments
 (0)