fix failing test conversation - should respect auto-assign preference when replying #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbinoj
commented
Oct 15, 2025
|
|
||
| await sendReplyMessage(page, "Auto-assign on test reply message"); | ||
| await expect(page.getByTestId("message-thread")).toContainText("Auto-assign on test reply message"); | ||
| await expect(page.getByRole("button", { name: "Assign yourself" })).not.toBeVisible(); |
Contributor
Author
There was a problem hiding this comment.
This is the line that causes the test failure.
From the video, it is evident that the user is being assigned, but the locator still exists.
Screen.Recording.2025-10-15.at.4.02.54.PM.mov
Contributor
Author
|
@slavingia can i have a review for this one? |
Collaborator
|
Looks great, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1064
Related Test
Problem
Previously, we checked for
Auto-Assign on Replyby locating theAssign yourselfbutton. However, it seems that this specific element is always present even when the conversation is already assigned to the user.This change was introduced by devin #1057
Video-proof :
Screen.Recording.2025-10-15.at.4.07.27.PM.mov
Solution
Instead of checking if
Assign yourselfbutton is present or not, we check if the assignee is user or not.Test passing screen shot
Link to upstream CI action passing all test suites:
https://github.com/stefanbinoj/helper/actions/runs/18527904075/job/52802976944
AI Usage :
No AI was used in the creation of this PR.
Self Review :
I have self reviewed all codes that i have written.