Update playwright.config for Improved Logging and Reduced Retries
#1073
Conversation
|
|
||
| - name: Upload Playwright HTML report | ||
| if: always() | ||
| if: ${{ !cancelled() }} |
|
@slavingia can i get a review? |
playwright.config.ts
Outdated
| workers: process.env.CI ? "100%" : undefined, | ||
| /* Reporter to use. See https://playwright.dev/docs/test-reporters */ | ||
| reporter: [["html", { open: process.env.CI ? "never" : "on-failure" }]], | ||
| reporter: process.env.CI ? [["list"], ["html"]] : "list", |
There was a problem hiding this comment.
Can you add github formatter to the CI list? It would be nice to see why the spec failed in PR reviews.
Actually I don't remember if it'd be displayed in Files changed tab but it should show up on actions run and here. We can try once maybe by failing a spec intentionally?
One caveat is there would be a slight increase in CI time, so we'll have to track it
There was a problem hiding this comment.
| reporter: process.env.CI ? [["list"], ["html"]] : "list", | |
| reporter: [["list"], ["html", { open: process.env.CI ? "never" : "on-failure" }], ["github"], |
There was a problem hiding this comment.
@sm17p Thanks for the comment, but it seems there’s no change in the report after switching togithub
check here
There was a problem hiding this comment.
Can you try by failing a spec?
There was a problem hiding this comment.
Still doesn’t seem like it’s anything worthwhile here
There was a problem hiding this comment.
I can see the annotations now at both the places though
2 participants
ref #1064
Changes
AI Disclosure
No AI was used for any part of this contribution.
Self Review
All changes have been reviewed and tested by myself.
Live Stream Disclosure
Viewed both live streams of antiwork and guidelines to follow