Skip to content

Commit 0879f5b

Browse files
authored
MINOR: [C++][Parquet] Fix *_write_page_index and set_size_statistics_level comments (#48299)
### Rationale for this change Defaults were changed in this commit 1fcc892 ### What changes are included in this PR? Fixed comments about default values of some writer properties ### Are these changes tested? No need to test ### Are there any user-facing changes? No Lead-authored-by: chegoryu <[email protected]> Co-authored-by: Egor Chunaev <[email protected]> Signed-off-by: Gang Wu <[email protected]>
1 parent db6ac11 commit 0879f5b

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

cpp/src/parquet/properties.h

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,7 @@ class PARQUET_EXPORT WriterProperties {
700700
return this;
701701
}
702702

703-
/// Enable writing page index in general for all columns. Default disabled.
703+
/// Enable writing page index in general for all columns. Default enabled.
704704
///
705705
/// Writing statistics to the page index disables the old method of writing
706706
/// statistics to each data page header.
@@ -715,35 +715,36 @@ class PARQUET_EXPORT WriterProperties {
715715
return this;
716716
}
717717

718-
/// Disable writing page index in general for all columns. Default disabled.
718+
/// Disable writing page index in general for all columns. Default enabled.
719719
Builder* disable_write_page_index() {
720720
default_column_properties_.set_page_index_enabled(false);
721721
return this;
722722
}
723723

724-
/// Enable writing page index for column specified by `path`. Default disabled.
724+
/// Enable writing page index for column specified by `path`. Default enabled.
725725
Builder* enable_write_page_index(const std::string& path) {
726726
page_index_enabled_[path] = true;
727727
return this;
728728
}
729729

730-
/// Enable writing page index for column specified by `path`. Default disabled.
730+
/// Enable writing page index for column specified by `path`. Default enabled.
731731
Builder* enable_write_page_index(const std::shared_ptr<schema::ColumnPath>& path) {
732732
return this->enable_write_page_index(path->ToDotString());
733733
}
734734

735-
/// Disable writing page index for column specified by `path`. Default disabled.
735+
/// Disable writing page index for column specified by `path`. Default enabled.
736736
Builder* disable_write_page_index(const std::string& path) {
737737
page_index_enabled_[path] = false;
738738
return this;
739739
}
740740

741-
/// Disable writing page index for column specified by `path`. Default disabled.
741+
/// Disable writing page index for column specified by `path`. Default enabled.
742742
Builder* disable_write_page_index(const std::shared_ptr<schema::ColumnPath>& path) {
743743
return this->disable_write_page_index(path->ToDotString());
744744
}
745745

746-
/// \brief Set the level to write size statistics for all columns. Default is None.
746+
/// \brief Set the level to write size statistics for all columns. Default is
747+
/// PageAndColumnChunk.
747748
///
748749
/// \param level The level to write size statistics. Note that if page index is not
749750
/// enabled, page level size statistics will not be written even if the level

0 commit comments

Comments
 (0)