Skip to content

Commit 3af2e42

Browse files
authored
Bugfix: Java 25 broke test (#1657)
As test was naively using `new File("")` assuming its method `file.list()` will return `null` on cleanup in `teardown()` method. But, it turns out it was an old Java bug fixed in Java 25, and once GH matrix got Java 25 introduced, it broke the build. Refs: * https://bugs.openjdk.org/browse/JDK-8024695 * https://inside.java/2025/11/03/quality-heads-up/ Thanks to @sormuras
1 parent 7fef652 commit 3af2e42

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/maven-verify.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ jobs:
2626
name: Verify
2727
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4
2828
with:
29+
ff-run: false
2930
ff-site-run: false
30-
maven-matrix: '[ "3.9.9" ]'
31-
32-
31+
maven4-enabled: true
32+
verify-fail-fast: false
33+

maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,7 @@ public void testFindInLocalRepositoryWhenVersionWasFoundInLocalRepository() thro
761761
session.setLocalRepositoryManager(new LocalRepositoryManager() {
762762

763763
public LocalRepository getRepository() {
764-
return new LocalRepository(new File(""));
764+
return new LocalRepository(lrm.getRepository().getBasedir());
765765
}
766766

767767
public String getPathForRemoteMetadata(Metadata metadata, RemoteRepository repository, String context) {
@@ -828,7 +828,7 @@ public void testFindInLocalRepositoryWhenVersionRangeWasResolvedFromLocalReposit
828828
session.setLocalRepositoryManager(new LocalRepositoryManager() {
829829

830830
public LocalRepository getRepository() {
831-
return new LocalRepository(new File(""));
831+
return new LocalRepository(lrm.getRepository().getBasedir());
832832
}
833833

834834
public String getPathForRemoteMetadata(Metadata metadata, RemoteRepository repository, String context) {

0 commit comments

Comments
 (0)