Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Jun 11, 2025

Proxy falls back to HTTP but it may need to be HTTPS

Fixes #745

Proxy falls back to HTTP but it may need to be HTTPS

Fixes apache#745
@cstamas cstamas added this to the 1.9.24 milestone Jun 11, 2025
@cstamas cstamas changed the title Proxy protol loss Proxy protocol loss Jun 11, 2025
@cstamas cstamas marked this pull request as ready for review June 11, 2025 12:55
@cstamas cstamas self-assigned this Jun 11, 2025
@cstamas cstamas merged commit e1ee1ef into apache:maven-resolver-1.9.x Jun 11, 2025
11 checks passed
@cstamas cstamas deleted the maven-resolver-1.9.x-issue-745 branch June 11, 2025 20:40
@slawekjaranowski
Copy link
Member

please check if default label is ok for this changed...

I will fix a draft of release notes 😸

@cstamas cstamas added bug Something isn't working and removed maintenance labels Jun 11, 2025
@cstamas
Copy link
Member Author

cstamas commented Jun 11, 2025

Changed to bug

cstamas added a commit that referenced this pull request Jun 26, 2025
Also the added UTs made no sense from retrospective, as they used HTTP remote repo with HTTPS proxy, something Maven would never do.

Rolls back #747 but leaves traces and some context.
Ref apache/maven#2519
@slawekjaranowski slawekjaranowski modified the milestone: 1.9.24 Jun 26, 2025
@slawekjaranowski slawekjaranowski added skip-changelog Skip this PR from automatically changelog generation and removed bug Something isn't working labels Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip this PR from automatically changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants