Skip to content

Commit 34a61dc

Browse files
committed
Fix build script
1 parent 3bb9d78 commit 34a61dc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/build-wheel-inside-docker.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ fi
3131
PULSAR_CPP_VERSION=$(cat ./dependencies.yaml | grep pulsar-cpp | awk '{print $2}')
3232

3333
if [ $CPP_BINARY_TYPE == "rpm" ]; then
34-
# The pre-built RPM packages have incompatible ABI with manylinux2014, so we have to build from source
34+
# The pre-built RPM packages have incompatible ABI with manylinux, so we have to build from source
3535
download_dependency ./dependencies.yaml pulsar-cpp
3636
cd apache-pulsar-client-cpp-${PULSAR_CPP_VERSION}
3737

3838
git clone https://github.com/microsoft/vcpkg.git
3939
cd vcpkg
4040

41-
# manylinux2014 does not have ninja in the system package manager
41+
# manylinux does not have ninja in the system package manager
4242
git clone https://github.com/ninja-build/ninja.git
4343
cd ninja
4444
git checkout release
@@ -48,7 +48,7 @@ if [ $CPP_BINARY_TYPE == "rpm" ]; then
4848
./bootstrap-vcpkg.sh
4949
cd ..
5050
if [ $PULSAR_CPP_VERSION == "3.7.0" ]; then
51-
patch lib/CMakeLists.txt $ROOT_DIR/pkg/manylinux2014/pulsar-client-cpp-3.7.0.patch
51+
patch lib/CMakeLists.txt $ROOT_DIR/pkg/manylinux/pulsar-client-cpp-3.7.0.patch
5252
fi
5353
cmake -B build-cpp -DINTEGRATE_VCPKG=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTS=OFF -DBUILD_DYNAMIC_LIB=ON -DBUILD_STATIC_LIB=ON
5454
cmake --build build-cpp -j8 --target install

0 commit comments

Comments
 (0)