Skip to content

Commit 9abe20e

Browse files
committed
fix: Updating the logo in the app editor to use favicon instead (#41147)
## Description Updating the logo in the app editor to use favicon instead Fixes [#41134](#41134) ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/16591754385> > Commit: 29ca678 > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` > Spec: `` > <hr>Tue, 29 Jul 2025 09:11:02 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Updated the logo in the Appsmith link to display the organization's favicon if available and different from the default, otherwise defaults to the standard logo. * **Bug Fixes** * Increased the maximum allowed favicon size in branding settings from 32x32 to 48x48 pixels, with updated validation and messaging. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 58ef103 commit 9abe20e

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

app/client/src/ce/constants/messages.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1698,13 +1698,13 @@ export const ADMIN_BRANDING_LOGO_FORMAT_ERROR = () =>
16981698
export const ADMIN_BRANDING_LOGO_REQUIREMENT = () =>
16991699
`.SVG, .PNG, or .JPG only • Max 2MB`;
17001700
export const ADMIN_BRANDING_FAVICON_DIMENSION_ERROR = () =>
1701-
`Uploaded file must have a max size of 32X32 pixels`;
1701+
`Uploaded file must have a max size of 48X48 pixels`;
17021702
export const ADMIN_BRANDING_FAVICON_SIZE_ERROR = () =>
17031703
`Uploaded file must be less than 2MB`;
17041704
export const ADMIN_BRANDING_FAVICON_FORMAT_ERROR = () =>
17051705
`Uploaded file must be in .ICO, .PNG, and .JPG formats`;
17061706
export const ADMIN_BRANDING_FAVICON_REQUIREMENT = () =>
1707-
`.ICO, .PNG, or .JPG only • Max 32X32`;
1707+
`.ICO, .PNG, or .JPG only • Max 48X48`;
17081708
export const PROFILE_DISPLAY_PICTURE_REQUIREMENT = () =>
17091709
`.ICO, .PNG, or .JPG only • Max 32X32`;
17101710
export const ADMIN_BRANDING_COLOR_TOOLTIP_PRIMARY = () =>

app/client/src/pages/Editor/AppsmithLink.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const StyledLink = styled((props) => {
2222
min-width: 24px;
2323
width: 24px;
2424
height: 24px;
25-
object-fit: contain;
2625
}
2726
`;
2827

@@ -49,8 +48,10 @@ export const AppsmithLink = () => {
4948
alt="Appsmith logo"
5049
className="t--appsmith-logo"
5150
src={
52-
organizationConfig.brandLogoUrl
53-
? organizationConfig.brandLogoUrl
51+
organizationConfig.brandFaviconUrl &&
52+
organizationConfig.brandFaviconUrl !==
53+
"https://assets.appsmith.com/appsmith-favicon-orange.ico"
54+
? organizationConfig.brandFaviconUrl
5455
: AppsmithLogo
5556
}
5657
/>

app/client/src/utils/BrandingUtils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import { ASSETS_CDN_URL } from "constants/ThirdPartyConstants";
1313
import { getAssetUrl } from "ee/utils/airgapHelpers";
1414
import { LightModeTheme } from "@appsmith/wds-theming";
1515

16-
const FAVICON_MAX_WIDTH = 32;
17-
const FAVICON_MAX_HEIGHT = 32;
16+
const FAVICON_MAX_WIDTH = 48;
17+
const FAVICON_MAX_HEIGHT = 48;
1818
const DEFAULT_BRANDING_PRIMARY_COLOR = "#E15615";
1919

2020
export const APPSMITH_BRAND_PRIMARY_COLOR =

0 commit comments

Comments
 (0)