Update to Selenium v.4.36.0, update core to migrate from Newthonsoft.Json to System.Text.Json +semver: feature (#275)

* Update to Selenium v.4.36.0, update core to migrate from Newthonsoft.Json to System.Text.Json  +semver: feature

* Update core version, stabilize tests, update DevTools references to use V140

* Stabilize findByImage test

fixes #274

Author: mialeska

Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj

@@ -91,7 +91,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Aquality.Selenium.Core" Version="3.5.0" />
+    <PackageReference Include="Aquality.Selenium.Core" Version="4.1.0" />
     <PackageReference Include="WebDriverManager" Version="2.17.6" />
   </ItemGroup>
 

Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml

@@ -1,7 +1,7 @@
 using Aquality.Selenium.Core.Utilities;
 using OpenQA.Selenium.DevTools;
-using OpenQA.Selenium.DevTools.V138.DOM;
-using OpenQA.Selenium.DevTools.V138.Emulation;
+using OpenQA.Selenium.DevTools.V140.DOM;
+using OpenQA.Selenium.DevTools.V140.Emulation;
 using System;
 using System.Collections.Generic;
 using System.Linq;

Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs

@@ -1,4 +1,4 @@
-using OpenQA.Selenium.DevTools.V138.Performance;
+using OpenQA.Selenium.DevTools.V140.Performance;
 using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;

Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsPerformanceExtensions.cs

@@ -30,11 +30,11 @@
 
   <ItemGroup>
     <PackageReference Include="nunit" Version="4.4.0" />
-    <PackageReference Include="NUnit3TestAdapter" Version="5.1.0">
+    <PackageReference Include="NUnit3TestAdapter" Version="5.2.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
   </ItemGroup>
 
   <ItemGroup>

Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj

@@ -59,11 +59,11 @@ public void Should_BePossibleTo_SetAndClearDeviceMetricsOverride_WithVersionSpec
         {
             void setAction(long width, long height, bool isMobile, double scaleFactor)
             {
-                var parameters = new OpenQA.Selenium.DevTools.V138.Emulation.SetDeviceMetricsOverrideCommandSettings
+                var parameters = new SetDeviceMetricsOverrideCommandSettings
                 {
-                    DisplayFeature = new OpenQA.Selenium.DevTools.V138.Emulation.DisplayFeature
+                    DisplayFeature = new DisplayFeature
                     {
-                        Orientation = OpenQA.Selenium.DevTools.V138.Emulation.DisplayFeatureOrientationValues.Horizontal
+                        Orientation = DisplayFeatureOrientationValues.Horizontal
                     },
                     Width = width,
                     Height = height,

Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/DevToolsEmulationTests.cs

@@ -9,6 +9,7 @@ namespace Aquality.Selenium.Tests.Integration
 {
     internal class ImageLocatorTests : UITest
     {
+        private const string ImageTag = "img";
         private readonly BrokenImagesForm form = new();
 
         [Test, Category(RetriesGroup), Retry(RetriesCount)]
@@ -18,26 +19,26 @@ public void Should_BePossibleTo_FindByImage()
             Assert.That(form.LabelByImage.State.IsDisplayed, Is.False, "Should be impossible to find element on page by image when it is absent");
             form.Open();
             Assert.That(form.LabelByImage.State.IsDisplayed, "Should be possible to find element on page by image");
-            Assert.That(form.LabelByImage.GetElement().TagName, Is.EqualTo("img"), "Correct element must be found");
+            Assert.That(form.LabelByImage.GetElement().TagName, Is.EqualTo(ImageTag), "Correct element must be found");
 
             var childLabels = form.ChildLabelsByImage;
             var docLabels = form.LabelsByImage;
             Assert.That(docLabels.Count, Is.GreaterThan(1), "List of elements should be possible to find by image");
             Assert.That(docLabels.Count, Is.EqualTo(childLabels.Count), "Should be possible to find child elements by image with the same count");
 
-            var documentByTag = AqualityServices.Get<IElementFactory>().GetLabel(By.TagName("body"), "document by tag");
+            var imageByTag = AqualityServices.Get<IElementFactory>().GetLabel(By.TagName(ImageTag), "Image by tag");
             var fullThreshold = 1;
-            var getDocByImage = () => AqualityServices.Get<IElementFactory>().GetLabel(new ByImage(documentByTag.GetElement().GetScreenshot().AsByteArray) { Threshold = fullThreshold },
-                    "body screen");
+            var getDocByImage = () => AqualityServices.Get<IElementFactory>().GetLabel(new ByImage(imageByTag.GetElement().GetScreenshot().AsByteArray) { Threshold = fullThreshold },
+                    "image by screenshot");
             ILabel documentByImage = getDocByImage();
-            AqualityServices.ConditionalWait.WaitForTrue(() =>
+            AqualityServices.ConditionalWait.WaitFor(() =>
             {
                 documentByImage = getDocByImage();
                 return documentByImage.State.IsDisplayed;
             });
-            Assert.That(documentByImage.State.IsDisplayed, "Should be possible to find element by document screenshot");
+            Assert.That(documentByImage.State.IsDisplayed, "Should be possible to find element by screenshot");
             Assert.That((documentByImage.Locator as ByImage)?.Threshold, Is.EqualTo(fullThreshold), "Should be possible to get ByImage threshold");
-            Assert.That(documentByImage.GetElement().TagName, Is.EqualTo("body"), "Correct element must be found");
+            Assert.That(documentByImage.GetElement().TagName, Is.EqualTo(ImageTag), "Correct element must be found");
         }
     }
 }

Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/ImageLocatorTests.cs

@@ -23,8 +23,11 @@ public LocationForm() : base(By.Id("accordion"), "My Location")
 
         public void DismissCookieInfo()
         {
-            consentCookieInfoButton.Click();
-            consentCookieInfoButton.State.WaitForNotDisplayed();
+            if (consentCookieInfoButton.State.WaitForDisplayed())
+            {
+                consentCookieInfoButton.Click();
+                consentCookieInfoButton.State.WaitForNotDisplayed();
+            }
             if (gotItCookieButton.State.WaitForDisplayed())
             {
                 gotItCookieButton.Click();

Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/TestApp/MyLocation/LocationForm.cs

@@ -24,7 +24,7 @@ public void Should_BePossibleToUse_BrowserFromCustomFactory()
             var browserFactory = new CustomLocalBrowserFactory();
             AqualityServices.Browser = browserFactory.Browser;
             AqualityServices.Browser.GoTo(url);
-            Assert.That(AqualityServices.Browser.CurrentUrl, Is.EqualTo(url));
+            Assert.That(AqualityServices.Browser.CurrentUrl, Does.StartWith(url));
         }
 
         [Test]
@@ -33,7 +33,7 @@ public void Should_BePossibleToUse_CustomFactory()
             var browserFactory = new CustomLocalBrowserFactory();
             AqualityServices.BrowserFactory = browserFactory;
             AqualityServices.Browser.GoTo(url);
-            Assert.That(AqualityServices.Browser.CurrentUrl, Is.EqualTo(url));
+            Assert.That(AqualityServices.Browser.CurrentUrl, Does.StartWith(url));
         }
 
         [TearDown]