Fixes #746

Author: ardalis

sample/src/NimblePros.SampleToDo.Core/ProjectAggregate/Priority.cs

@@ -0,0 +1,11 @@
+using Ardalis.SmartEnum;
+
+namespace NimblePros.SampleToDo.Core.ProjectAggregate;
+
+public class Priority : SmartEnum<Priority>
+{
+  public static readonly Priority Backlog = new(nameof(Backlog), 0);
+  public static readonly Priority Critical = new(nameof(Critical), 1);
+
+  protected Priority(string name, int value) : base(name, value) { }
+}

sample/src/NimblePros.SampleToDo.Core/ProjectAggregate/PriorityStatus.cs

@@ -12,17 +12,18 @@ public class Project : EntityBase, IAggregateRoot
   public IEnumerable<ToDoItem> Items => _items.AsReadOnly();
   public ProjectStatus Status => _items.All(i => i.IsDone) ? ProjectStatus.Complete : ProjectStatus.InProgress;
 
-  public PriorityStatus Priority { get; }
+  // Note: Probably it makes more sense to prioritize items, not projects, but this is just an example
+  public Priority Priority { get; }
 
-  public Project(string name, PriorityStatus priority)
+  public Project(string name, Priority priority)
   {
-    Name = Guard.Against.NullOrEmpty(name, nameof(name));
+    Name = Guard.Against.NullOrEmpty(name);
     Priority = priority;
   }
 
   public void AddItem(ToDoItem newItem)
   {
-    Guard.Against.Null(newItem, nameof(newItem));
+    Guard.Against.Null(newItem);
     _items.Add(newItem);
 
     var newItemAddedEvent = new NewItemAddedEvent(this, newItem);
@@ -31,6 +32,6 @@ public void AddItem(ToDoItem newItem)
 
   public void UpdateName(string newName)
   {
-    Name = Guard.Against.NullOrEmpty(newName, nameof(newName));
+    Name = Guard.Against.NullOrEmpty(newName);
   }
 }

sample/src/NimblePros.SampleToDo.Core/ProjectAggregate/Project.cs

@@ -15,6 +15,6 @@ public void Configure(EntityTypeBuilder<Project> builder)
     builder.Property(p => p.Priority)
       .HasConversion(
           p => p.Value,
-          p => PriorityStatus.FromValue(p));
+          p => Priority.FromValue(p));
   }
 }

sample/src/NimblePros.SampleToDo.Infrastructure/Data/Config/ProjectConfiguration.cs

@@ -16,7 +16,7 @@ public CreateProjectHandler(IRepository<Project> repository)
   public async Task<Result<int>> Handle(CreateProjectCommand request,
     CancellationToken cancellationToken)
   {
-    var newProject = new Project(request.Name, PriorityStatus.Backlog);
+    var newProject = new Project(request.Name, Priority.Backlog);
     var createdItem = await _repository.AddAsync(newProject, cancellationToken);
 
     return createdItem.Id;

sample/src/NimblePros.SampleToDo.UseCases/Projects/Create/CreateProjectHandler.cs

@@ -9,7 +9,7 @@ public static class SeedData
 {
   public static readonly Contributor Contributor1 = new ("Ardalis");
   public static readonly Contributor Contributor2 = new ("Snowfrog");
-  public static readonly Project TestProject1 = new Project("Test Project", PriorityStatus.Backlog);
+  public static readonly Project TestProject1 = new Project("Test Project", Priority.Backlog);
   public static readonly ToDoItem ToDoItem1 = new ToDoItem
   {
     Title = "Get Sample Working",

sample/src/NimblePros.SampleToDo.Web/SeedData.cs

@@ -9,17 +9,17 @@ public class EfRepositoryAdd : BaseEfRepoTestFixture
   public async Task AddsProjectAndSetsId()
   {
     var testProjectName = "testProject";
-    var testProjectStatus = PriorityStatus.Backlog;
+    var testProjectPriority = Priority.Backlog;
     var repository = GetRepository();
-    var project = new Project(testProjectName, testProjectStatus);
+    var project = new Project(testProjectName, testProjectPriority);
 
     await repository.AddAsync(project);
 
     var newProject = (await repository.ListAsync())
                     .FirstOrDefault();
 
     Assert.Equal(testProjectName, newProject?.Name);
-    Assert.Equal(testProjectStatus, newProject?.Priority);
+    Assert.Equal(testProjectPriority, newProject?.Priority);
     Assert.True(newProject?.Id > 0);
   }
 }

sample/tests/NimblePros.SampleToDo.IntegrationTests/Data/EfRepositoryAdd.cs

@@ -11,7 +11,7 @@ public async Task DeletesItemAfterAddingIt()
     // add a project
     var repository = GetRepository();
     var initialName = Guid.NewGuid().ToString();
-    var project = new Project(initialName, PriorityStatus.Backlog);
+    var project = new Project(initialName, Priority.Backlog);
     await repository.AddAsync(project);
 
     // delete the item

sample/tests/NimblePros.SampleToDo.IntegrationTests/Data/EfRepositoryDelete.cs

@@ -12,7 +12,7 @@ public async Task UpdatesItemAfterAddingIt()
     // add a project
     var repository = GetRepository();
     var initialName = Guid.NewGuid().ToString();
-    var project = new Project(initialName, PriorityStatus.Backlog);
+    var project = new Project(initialName, Priority.Backlog);
 
     await repository.AddAsync(project);
 

sample/tests/NimblePros.SampleToDo.IntegrationTests/Data/EfRepositoryUpdate.cs

@@ -6,7 +6,7 @@ namespace NimblePros.SampleToDo.UnitTests.Core.ProjectAggregate;
 public class ProjectConstructor
 {
   private string _testName = "test name";
-  private PriorityStatus _testPriority = PriorityStatus.Backlog;
+  private Priority _testPriority = Priority.Backlog;
   private Project? _testProject;
 
   private Project CreateProject()