Add tests (#454)

* Added tests. Full coverage for the base package.

* Added tests for EF Core package.

Author: fiseni

src/Ardalis.Specification.EntityFrameworkCore/Evaluators/SpecificationEvaluator.cs

@@ -10,12 +10,12 @@ public class SpecificationEvaluator : ISpecificationEvaluator
     /// </summary>
     public static SpecificationEvaluator Default { get; } = new SpecificationEvaluator();
 
-    protected List<IEvaluator> Evaluators { get; } = new List<IEvaluator>();
+    protected List<IEvaluator> Evaluators { get; }
 
     public SpecificationEvaluator()
     {
-        Evaluators.AddRange(new IEvaluator[]
-        {
+        Evaluators =
+        [
             WhereEvaluator.Instance,
             SearchEvaluator.Instance,
             IncludeStringEvaluator.Instance,
@@ -29,12 +29,12 @@ public SpecificationEvaluator()
             IgnoreAutoIncludesEvaluator.Instance,
             AsSplitQueryEvaluator.Instance,
             TagWithEvaluator.Instance,
-        });
+        ];
     }
 
     public SpecificationEvaluator(IEnumerable<IEvaluator> evaluators)
     {
-        Evaluators.AddRange(evaluators);
+        Evaluators = evaluators.ToList();
     }
 
     /// <inheritdoc/>

src/Ardalis.Specification/Evaluators/InMemorySpecificationEvaluator.cs

@@ -5,21 +5,22 @@ public class InMemorySpecificationEvaluator : IInMemorySpecificationEvaluator
     // Will use singleton for default configuration. Yet, it can be instantiated if necessary, with default or provided evaluators.
     public static InMemorySpecificationEvaluator Default { get; } = new InMemorySpecificationEvaluator();
 
-    protected List<IInMemoryEvaluator> Evaluators { get; } = new List<IInMemoryEvaluator>();
+    protected List<IInMemoryEvaluator> Evaluators { get; }
 
     public InMemorySpecificationEvaluator()
     {
-        Evaluators.AddRange(new IInMemoryEvaluator[]
-        {
+        Evaluators =
+        [
             WhereEvaluator.Instance,
             SearchMemoryEvaluator.Instance,
             OrderEvaluator.Instance,
             PaginationEvaluator.Instance
-        });
+        ];
     }
+
     public InMemorySpecificationEvaluator(IEnumerable<IInMemoryEvaluator> evaluators)
     {
-        Evaluators.AddRange(evaluators);
+        Evaluators = evaluators.ToList();
     }
 
     public virtual IEnumerable<TResult> Evaluate<T, TResult>(IEnumerable<T> source, ISpecification<T, TResult> specification)

src/Ardalis.Specification/Evaluators/Iterator.cs

@@ -21,8 +21,12 @@ public Iterator<TSource> GetEnumerator()
     public abstract bool MoveNext();
 
     public TSource Current => _current;
-    object? IEnumerator.Current => Current;
     IEnumerator<TSource> IEnumerable<TSource>.GetEnumerator() => GetEnumerator();
+
+    [ExcludeFromCodeCoverage]
+    object? IEnumerator.Current => Current;
+
+    [ExcludeFromCodeCoverage]
     IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
 
     [ExcludeFromCodeCoverage]

src/Ardalis.Specification/Exceptions/ConcurrentSelectorsException.cs

@@ -2,15 +2,15 @@
 
 public class ConcurrentSelectorsException : Exception
 {
-    private const string _message = "Concurrent specification selector transforms defined. Ensure only one of the Select() or SelectMany() transforms is used in the same specification!";
+    private const string MESSAGE = "Concurrent specification selector transforms defined. Ensure only one of the Select() or SelectMany() transforms is used in the same specification!";
 
     public ConcurrentSelectorsException()
-        : base(_message)
+        : base(MESSAGE)
     {
     }
 
     public ConcurrentSelectorsException(Exception innerException)
-        : base(_message, innerException)
+        : base(MESSAGE, innerException)
     {
     }
 }

src/Ardalis.Specification/Exceptions/DuplicateOrderChainException.cs

@@ -2,15 +2,15 @@
 
 public class DuplicateOrderChainException : Exception
 {
-    private const string _message = "The specification contains more than one Order chain!";
+    private const string MESSAGE = "The specification contains more than one Order chain!";
 
     public DuplicateOrderChainException()
-        : base(_message)
+        : base(MESSAGE)
     {
     }
 
     public DuplicateOrderChainException(Exception innerException)
-        : base(_message, innerException)
+        : base(MESSAGE, innerException)
     {
     }
 }

src/Ardalis.Specification/Exceptions/DuplicateSkipException.cs

@@ -2,15 +2,15 @@
 
 public class DuplicateSkipException : Exception
 {
-    private const string _message = "Duplicate use of Skip(). Ensure you don't use Skip() more than once in the same specification!";
+    private const string MESSAGE = "Duplicate use of Skip(). Ensure you don't use Skip() more than once in the same specification!";
 
     public DuplicateSkipException()
-        : base(_message)
+        : base(MESSAGE)
     {
     }
 
     public DuplicateSkipException(Exception innerException)
-        : base(_message, innerException)
+        : base(MESSAGE, innerException)
     {
     }
 }

src/Ardalis.Specification/Exceptions/DuplicateTakeException.cs

@@ -2,15 +2,15 @@
 
 public class DuplicateTakeException : Exception
 {
-    private const string _message = "Duplicate use of Take(). Ensure you don't use Take() more than once in the same specification!";
+    private const string MESSAGE = "Duplicate use of Take(). Ensure you don't use Take() more than once in the same specification!";
 
     public DuplicateTakeException()
-        : base(_message)
+        : base(MESSAGE)
     {
     }
 
     public DuplicateTakeException(Exception innerException)
-        : base(_message, innerException)
+        : base(MESSAGE, innerException)
     {
     }
 }

src/Ardalis.Specification/Exceptions/InvalidSearchPatternException.cs

@@ -2,15 +2,15 @@
 
 public class InvalidSearchPatternException : Exception
 {
-    private const string _message = "Invalid search pattern: ";
+    private const string MESSAGE = "Invalid search pattern: ";
 
     public InvalidSearchPatternException(string searchPattern)
-        : base($"{_message}{searchPattern}")
+        : base($"{MESSAGE}{searchPattern}")
     {
     }
 
     public InvalidSearchPatternException(string searchPattern, Exception innerException)
-        : base($"{_message}{searchPattern}", innerException)
+        : base($"{MESSAGE}{searchPattern}", innerException)
     {
     }
 }

src/Ardalis.Specification/Exceptions/SelectorNotFoundException.cs

@@ -2,15 +2,15 @@
 
 public class SelectorNotFoundException : Exception
 {
-    private const string _message = "The specification must have a selector transform defined. Ensure either Select() or SelectMany() is used in the specification!";
+    private const string MESSAGE = "The specification must have a selector transform defined. Ensure either Select() or SelectMany() is used in the specification!";
 
     public SelectorNotFoundException()
-        : base(_message)
+        : base(MESSAGE)
     {
     }
 
     public SelectorNotFoundException(Exception innerException)
-        : base(_message, innerException)
+        : base(MESSAGE, innerException)
     {
     }
 }

src/Ardalis.Specification/Validators/SpecificationValidator.cs

@@ -5,24 +5,25 @@ public class SpecificationValidator : ISpecificationValidator
     // Will use singleton for default configuration. Yet, it can be instantiated if necessary, with default or provided validators.
     public static SpecificationValidator Default { get; } = new SpecificationValidator();
 
-    private readonly List<IValidator> _validators = new();
+    protected List<IValidator> Validators { get; }
 
     public SpecificationValidator()
     {
-        _validators.AddRange(new IValidator[]
-        {
+        Validators =
+        [
             WhereValidator.Instance,
             SearchValidator.Instance
-        });
+        ];
     }
+
     public SpecificationValidator(IEnumerable<IValidator> validators)
     {
-        _validators.AddRange(validators);
+        Validators = validators.ToList();
     }
 
     public virtual bool IsValid<T>(T entity, ISpecification<T> specification)
     {
-        foreach (var partialValidator in _validators)
+        foreach (var partialValidator in Validators)
         {
             if (partialValidator.IsValid(entity, specification) == false) return false;
         }