test: add logging statements when we wait for something in e2e tests

kostis-codefresh · kostis-codefresh · commit 56d8aad23ea7 · 2025-08-18T19:11:34.000+03:00
Signed-off-by: Kostis Kapelonis &lt;kostis@codefresh.io&gt;
diff --git a/test/e2e/single_grpcroute_test.go b/test/e2e/single_grpcroute_test.go
@@ -107,6 +107,7 @@ func setupSingleGRPCRouteEnv(ctx context.Context, t *testing.T, config *envconf.
 	}
 	logrus.Infof("rollout %q was created", resourcesMap[ROLLOUT_KEY].GetName())
 	waitCondition := conditions.New(clusterResources)
+	logrus.Infof("waiting for grpcRoute %q to connect with rollout %q (expecting canary weight: %d)", resourcesMap[GRPC_ROUTE_KEY].GetName(), resourcesMap[ROLLOUT_KEY].GetName(), FIRST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[GRPC_ROUTE_KEY],
@@ -180,6 +181,7 @@ func testSingleGRPCRoute(ctx context.Context, t *testing.T, config *envconf.Conf
 	}
 	logrus.Infof("rollout %q was updated", resourcesMap[ROLLOUT_KEY].GetName())
 	waitCondition := conditions.New(clusterResources)
+	logrus.Infof("waiting for grpcRoute %q to update canary weight to %d after rollout image change", resourcesMap[GRPC_ROUTE_KEY].GetName(), LAST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[GRPC_ROUTE_KEY],
@@ -232,14 +234,14 @@ func getMatchGRPCRouteFetcher(t *testing.T, targetWeight int32) func(k8s.Object)
 			t.Error()
 			return false
 		}
-		logrus.Info("k8s object was type asserted")
+		// logrus.Info("k8s object was type asserted")
 		err := runtime.DefaultUnstructuredConverter.FromUnstructured(unstructuredGRPCRoute.Object, &grpcRoute)
 		if err != nil {
 			logrus.Errorf("conversation from unstructured grpcRoute %q to the typed grpcRoute was failed", unstructuredGRPCRoute.GetName())
 			t.Error()
 			return false
 		}
-		logrus.Infof("unstructured grpcRoute %q was converted to the typed grpcRoute", grpcRoute.GetName())
+		// logrus.Infof("Looking for grpcRoute %q to reach weight %d", grpcRoute.GetName(), targetWeight)
 		return *grpcRoute.Spec.Rules[ROLLOUT_ROUTE_RULE_INDEX].BackendRefs[CANARY_BACKEND_REF_INDEX].Weight == targetWeight
 	}
 }
diff --git a/test/e2e/single_header_based_grpcroute_test.go b/test/e2e/single_header_based_grpcroute_test.go
@@ -107,6 +107,7 @@ func setupSingleHeaderBasedGRPCRouteEnv(ctx context.Context, t *testing.T, confi
 	}
 	logrus.Infof("rollout %q was created", resourcesMap[ROLLOUT_KEY].GetName())
 	waitCondition := conditions.New(clusterResources)
+	logrus.Infof("waiting for grpcRoute %q to connect with rollout %q (expecting canary weight: %d)", resourcesMap[GRPC_ROUTE_KEY].GetName(), resourcesMap[ROLLOUT_KEY].GetName(), FIRST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[GRPC_ROUTE_KEY],
@@ -180,6 +181,7 @@ func testSingleHeaderBasedGRPCRoute(ctx context.Context, t *testing.T, config *e
 	}
 	logrus.Infof("rollout %q was updated", resourcesMap[ROLLOUT_KEY].GetName())
 	waitCondition := conditions.New(clusterResources)
+	logrus.Infof("waiting for grpcRoute %q to update with header-based routing and canary weight %d", resourcesMap[GRPC_ROUTE_KEY].GetName(), LAST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[GRPC_ROUTE_KEY],
@@ -198,6 +200,7 @@ func testSingleHeaderBasedGRPCRoute(ctx context.Context, t *testing.T, config *e
 		return ctx
 	}
 	logrus.Infof("grpcRoute %q was updated", resourcesMap[GRPC_ROUTE_KEY].GetName())
+	logrus.Infof("waiting for grpcRoute %q to clean up header-based routing and reset canary weight to %d", resourcesMap[GRPC_ROUTE_KEY].GetName(), FIRST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[GRPC_ROUTE_KEY],
@@ -254,14 +257,14 @@ func getMatchHeaderBasedGRPCRouteFetcher(t *testing.T, targetWeight int32, targe
 			t.Error()
 			return false
 		}
-		logrus.Info("k8s object was type asserted")
+		// logrus.Info("k8s object was type asserted")
 		err := runtime.DefaultUnstructuredConverter.FromUnstructured(unstructuredGRPCRoute.Object, &grpcRoute)
 		if err != nil {
 			logrus.Errorf("conversation from unstructured grpcRoute %q to the typed grpcRoute was failed", unstructuredGRPCRoute.GetName())
 			t.Error()
 			return false
 		}
-		logrus.Infof("unstructured grpcRoute %q was converted to the typed grpcRoute", grpcRoute.GetName())
+		// logrus.Infof("unstructured grpcRoute %q was converted to the typed grpcRoute", grpcRoute.GetName())
 		rules := grpcRoute.Spec.Rules
 		if targetHeaderBasedRouteValue.Type == nil {
 			return len(rules) == LAST_HEADER_BASED_RULES_LENGTH &&
diff --git a/test/e2e/single_header_based_httproute_test.go b/test/e2e/single_header_based_httproute_test.go
@@ -107,6 +107,7 @@ func setupSingleHeaderBasedHTTPRouteEnv(ctx context.Context, t *testing.T, confi
 	}
 	logrus.Infof("rollout %q was created", resourcesMap[ROLLOUT_KEY].GetName())
 	waitCondition := conditions.New(clusterResources)
+	logrus.Infof("waiting for httpRoute %q to connect with rollout %q (expecting canary weight: %d)", resourcesMap[HTTP_ROUTE_KEY].GetName(), resourcesMap[ROLLOUT_KEY].GetName(), FIRST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[HTTP_ROUTE_KEY],
@@ -180,6 +181,7 @@ func testSingleHeaderBasedHTTPRoute(ctx context.Context, t *testing.T, config *e
 	}
 	logrus.Infof("rollout %q was updated", resourcesMap[ROLLOUT_KEY].GetName())
 	waitCondition := conditions.New(clusterResources)
+	logrus.Infof("waiting for httpRoute %q to update with header-based routing and canary weight %d", resourcesMap[HTTP_ROUTE_KEY].GetName(), LAST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[HTTP_ROUTE_KEY],
@@ -198,6 +200,7 @@ func testSingleHeaderBasedHTTPRoute(ctx context.Context, t *testing.T, config *e
 		return ctx
 	}
 	logrus.Infof("httpRoute %q was updated", resourcesMap[HTTP_ROUTE_KEY].GetName())
+	logrus.Infof("waiting for httpRoute %q to clean up header-based routing and reset canary weight to %d", resourcesMap[HTTP_ROUTE_KEY].GetName(), FIRST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[HTTP_ROUTE_KEY],
@@ -254,14 +257,14 @@ func getMatchHeaderBasedHTTPRouteFetcher(t *testing.T, targetWeight int32, targe
 			t.Error()
 			return false
 		}
-		logrus.Info("k8s object was type asserted")
+		// logrus.Info("k8s object was type asserted")
 		err := runtime.DefaultUnstructuredConverter.FromUnstructured(unstructuredHTTPRoute.Object, &httpRoute)
 		if err != nil {
 			logrus.Errorf("conversation from unstructured httpRoute %q to the typed httpRoute was failed", unstructuredHTTPRoute.GetName())
 			t.Error()
 			return false
 		}
-		logrus.Infof("unstructured httpRoute %q was converted to the typed httpRoute", httpRoute.GetName())
+		// logrus.Infof("unstructured httpRoute %q was converted to the typed httpRoute", httpRoute.GetName())
 		rules := httpRoute.Spec.Rules
 		if targetHeaderBasedRouteValue.Type == nil {
 			return len(rules) == LAST_HEADER_BASED_RULES_LENGTH &&
diff --git a/test/e2e/single_httproute_test.go b/test/e2e/single_httproute_test.go
@@ -109,6 +109,7 @@ func setupSingleHTTPRouteEnv(ctx context.Context, t *testing.T, config *envconf.
 	}
 	logrus.Infof("rollout %q was created", resourcesMap[ROLLOUT_KEY].GetName())
 	waitCondition := conditions.New(clusterResources)
+	logrus.Infof("waiting for httpRoute %q to connect with rollout %q (expecting canary weight: %d)", resourcesMap[HTTP_ROUTE_KEY].GetName(), resourcesMap[ROLLOUT_KEY].GetName(), FIRST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[HTTP_ROUTE_KEY],
@@ -182,6 +183,7 @@ func testSingleHTTPRoute(ctx context.Context, t *testing.T, config *envconf.Conf
 	}
 	logrus.Infof("rollout %q was updated", resourcesMap[ROLLOUT_KEY].GetName())
 	waitCondition := conditions.New(clusterResources)
+	logrus.Infof("waiting for httpRoute %q to update canary weight to %d after rollout image change", resourcesMap[HTTP_ROUTE_KEY].GetName(), LAST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[HTTP_ROUTE_KEY],
@@ -234,14 +236,14 @@ func getMatchHTTPRouteFetcher(t *testing.T, targetWeight int32) func(k8s.Object)
 			t.Error()
 			return false
 		}
-		logrus.Info("k8s object was type asserted")
+		// logrus.Info("k8s object was type asserted")
 		err := runtime.DefaultUnstructuredConverter.FromUnstructured(unstructuredHTTPRoute.Object, &httpRoute)
 		if err != nil {
 			logrus.Errorf("conversation from unstructured httpRoute %q to the typed httpRoute was failed", unstructuredHTTPRoute.GetName())
 			t.Error()
 			return false
 		}
-		logrus.Infof("unstructured httpRoute %q was converted to the typed httpRoute", httpRoute.GetName())
+		// logrus.Infof("unstructured httpRoute %q was converted to the typed httpRoute", httpRoute.GetName())
 		return *httpRoute.Spec.Rules[ROLLOUT_ROUTE_RULE_INDEX].BackendRefs[CANARY_BACKEND_REF_INDEX].Weight == targetWeight
 	}
 }
diff --git a/test/e2e/single_tcproute_test.go b/test/e2e/single_tcproute_test.go
@@ -107,6 +107,7 @@ func setupSingleTCPRouteEnv(ctx context.Context, t *testing.T, config *envconf.C
 	}
 	logrus.Infof("rollout %q was created", resourcesMap[ROLLOUT_KEY].GetName())
 	waitCondition := conditions.New(clusterResources)
+	logrus.Infof("waiting for tcpRoute %q to connect with rollout %q (expecting canary weight: %d)", resourcesMap[TCP_ROUTE_KEY].GetName(), resourcesMap[ROLLOUT_KEY].GetName(), FIRST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[TCP_ROUTE_KEY],
@@ -180,6 +181,7 @@ func testSingleTCPRoute(ctx context.Context, t *testing.T, config *envconf.Confi
 	}
 	logrus.Infof("rollout %q was updated", resourcesMap[ROLLOUT_KEY].GetName())
 	waitCondition := conditions.New(clusterResources)
+	logrus.Infof("waiting for tcpRoute %q to update canary weight to %d after rollout image change", resourcesMap[TCP_ROUTE_KEY].GetName(), LAST_CANARY_ROUTE_WEIGHT)
 	err = wait.For(
 		waitCondition.ResourceMatch(
 			resourcesMap[TCP_ROUTE_KEY],
@@ -232,14 +234,14 @@ func getMatchTCPRouteFetcher(t *testing.T, targetWeight int32) func(k8s.Object)
 			t.Error()
 			return false
 		}
-		logrus.Info("k8s object was type asserted")
+		// logrus.Info("k8s object was type asserted")
 		err := runtime.DefaultUnstructuredConverter.FromUnstructured(unstructuredTCPRoute.Object, &tcpRoute)
 		if err != nil {
 			logrus.Errorf("conversation from unstructured tcpRoute %q to the typed tcpRoute was failed", unstructuredTCPRoute.GetName())
 			t.Error()
 			return false
 		}
-		logrus.Infof("unstructured tcpRoute %q was converted to the typed tcpRoute", tcpRoute.GetName())
+		// logrus.Infof("unstructured tcpRoute %q was converted to the typed tcpRoute", tcpRoute.GetName())
 		return *tcpRoute.Spec.Rules[ROLLOUT_ROUTE_RULE_INDEX].BackendRefs[CANARY_BACKEND_REF_INDEX].Weight == targetWeight
 	}
 }
diff --git a/test/e2e/testdata/single-grpcroute-rollout.yml b/test/e2e/testdata/single-grpcroute-rollout.yml
@@ -16,7 +16,7 @@ spec:
             namespace: default
       steps:
         - setWeight: 30
-        - pause: { 30 }
+        - pause: {  }
   revisionHistoryLimit: 1
   selector:
     matchLabels:
diff --git a/test/e2e/testdata/single-header-based-grpcroute-rollout.yml b/test/e2e/testdata/single-header-based-grpcroute-rollout.yml
@@ -26,7 +26,7 @@ spec:
             - headerName: X-Test
               headerValue:
                 exact: test  
-      - pause: { 30 }
+      - pause: {  }
   revisionHistoryLimit: 2
   selector:
     matchLabels:
diff --git a/test/e2e/testdata/single-header-based-httproute-rollout.yml b/test/e2e/testdata/single-header-based-httproute-rollout.yml
@@ -26,7 +26,7 @@ spec:
             - headerName: X-Test
               headerValue:
                 exact: test  
-      - pause: { 30 }
+      - pause: {  }
   revisionHistoryLimit: 2
   selector:
     matchLabels:
diff --git a/test/e2e/testdata/single-httproute-rollout.yml b/test/e2e/testdata/single-httproute-rollout.yml
@@ -16,7 +16,7 @@ spec:
             namespace: default
       steps:
         - setWeight: 30
-        - pause: { 30 }
+        - pause: {  }
   revisionHistoryLimit: 1
   selector:
     matchLabels:
diff --git a/test/e2e/testdata/single-tcproute-rollout.yml b/test/e2e/testdata/single-tcproute-rollout.yml
@@ -16,7 +16,7 @@ spec:
             namespace: default
       steps:
         - setWeight: 30
-        - pause: { 30 }
+        - pause: { }
   revisionHistoryLimit: 1
   selector:
     matchLabels:

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ func setupSingleGRPCRouteEnv(ctx context.Context, t testing.T, config envconf.`
`107`	`107`	`}`
`108`	`108`	`logrus.Infof("rollout %q was created", resourcesMap[ROLLOUT_KEY].GetName())`
`109`	`109`	`waitCondition := conditions.New(clusterResources)`
	`110`	`+ logrus.Infof("waiting for grpcRoute %q to connect with rollout %q (expecting canary weight: %d)", resourcesMap[GRPC_ROUTE_KEY].GetName(), resourcesMap[ROLLOUT_KEY].GetName(), FIRST_CANARY_ROUTE_WEIGHT)`
`110`	`111`	`err = wait.For(`
`111`	`112`	`waitCondition.ResourceMatch(`
`112`	`113`	`resourcesMap[GRPC_ROUTE_KEY],`
`@@ -180,6 +181,7 @@ func testSingleGRPCRoute(ctx context.Context, t testing.T, config envconf.Conf`
`180`	`181`	`}`
`181`	`182`	`logrus.Infof("rollout %q was updated", resourcesMap[ROLLOUT_KEY].GetName())`
`182`	`183`	`waitCondition := conditions.New(clusterResources)`
	`184`	`+ logrus.Infof("waiting for grpcRoute %q to update canary weight to %d after rollout image change", resourcesMap[GRPC_ROUTE_KEY].GetName(), LAST_CANARY_ROUTE_WEIGHT)`
`183`	`185`	`err = wait.For(`
`184`	`186`	`waitCondition.ResourceMatch(`
`185`	`187`	`resourcesMap[GRPC_ROUTE_KEY],`
`@@ -232,14 +234,14 @@ func getMatchGRPCRouteFetcher(t *testing.T, targetWeight int32) func(k8s.Object)`
`232`	`234`	`t.Error()`
`233`	`235`	`return false`
`234`	`236`	`}`
`235`		`- logrus.Info("k8s object was type asserted")`
	`237`	`+ // logrus.Info("k8s object was type asserted")`
`236`	`238`	`err := runtime.DefaultUnstructuredConverter.FromUnstructured(unstructuredGRPCRoute.Object, &grpcRoute)`
`237`	`239`	`if err != nil {`
`238`	`240`	`logrus.Errorf("conversation from unstructured grpcRoute %q to the typed grpcRoute was failed", unstructuredGRPCRoute.GetName())`
`239`	`241`	`t.Error()`
`240`	`242`	`return false`
`241`	`243`	`}`
`242`		`- logrus.Infof("unstructured grpcRoute %q was converted to the typed grpcRoute", grpcRoute.GetName())`
	`244`	`+ // logrus.Infof("Looking for grpcRoute %q to reach weight %d", grpcRoute.GetName(), targetWeight)`
`243`	`245`	`return *grpcRoute.Spec.Rules[ROLLOUT_ROUTE_RULE_INDEX].BackendRefs[CANARY_BACKEND_REF_INDEX].Weight == targetWeight`
`244`	`246`	`}`
`245`	`247`	`}`
Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,7 @@ func setupSingleHTTPRouteEnv(ctx context.Context, t testing.T, config envconf.`
`109`	`109`	`}`
`110`	`110`	`logrus.Infof("rollout %q was created", resourcesMap[ROLLOUT_KEY].GetName())`
`111`	`111`	`waitCondition := conditions.New(clusterResources)`
	`112`	`+ logrus.Infof("waiting for httpRoute %q to connect with rollout %q (expecting canary weight: %d)", resourcesMap[HTTP_ROUTE_KEY].GetName(), resourcesMap[ROLLOUT_KEY].GetName(), FIRST_CANARY_ROUTE_WEIGHT)`
`112`	`113`	`err = wait.For(`
`113`	`114`	`waitCondition.ResourceMatch(`
`114`	`115`	`resourcesMap[HTTP_ROUTE_KEY],`
`@@ -182,6 +183,7 @@ func testSingleHTTPRoute(ctx context.Context, t testing.T, config envconf.Conf`
`182`	`183`	`}`
`183`	`184`	`logrus.Infof("rollout %q was updated", resourcesMap[ROLLOUT_KEY].GetName())`
`184`	`185`	`waitCondition := conditions.New(clusterResources)`
	`186`	`+ logrus.Infof("waiting for httpRoute %q to update canary weight to %d after rollout image change", resourcesMap[HTTP_ROUTE_KEY].GetName(), LAST_CANARY_ROUTE_WEIGHT)`
`185`	`187`	`err = wait.For(`
`186`	`188`	`waitCondition.ResourceMatch(`
`187`	`189`	`resourcesMap[HTTP_ROUTE_KEY],`
`@@ -234,14 +236,14 @@ func getMatchHTTPRouteFetcher(t *testing.T, targetWeight int32) func(k8s.Object)`
`234`	`236`	`t.Error()`
`235`	`237`	`return false`
`236`	`238`	`}`
`237`		`- logrus.Info("k8s object was type asserted")`
	`239`	`+ // logrus.Info("k8s object was type asserted")`
`238`	`240`	`err := runtime.DefaultUnstructuredConverter.FromUnstructured(unstructuredHTTPRoute.Object, &httpRoute)`
`239`	`241`	`if err != nil {`
`240`	`242`	`logrus.Errorf("conversation from unstructured httpRoute %q to the typed httpRoute was failed", unstructuredHTTPRoute.GetName())`
`241`	`243`	`t.Error()`
`242`	`244`	`return false`
`243`	`245`	`}`
`244`		`- logrus.Infof("unstructured httpRoute %q was converted to the typed httpRoute", httpRoute.GetName())`
	`246`	`+ // logrus.Infof("unstructured httpRoute %q was converted to the typed httpRoute", httpRoute.GetName())`
`245`	`247`	`return *httpRoute.Spec.Rules[ROLLOUT_ROUTE_RULE_INDEX].BackendRefs[CANARY_BACKEND_REF_INDEX].Weight == targetWeight`
`246`	`248`	`}`
`247`	`249`	`}`
Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ func setupSingleTCPRouteEnv(ctx context.Context, t testing.T, config envconf.C`
`107`	`107`	`}`
`108`	`108`	`logrus.Infof("rollout %q was created", resourcesMap[ROLLOUT_KEY].GetName())`
`109`	`109`	`waitCondition := conditions.New(clusterResources)`
	`110`	`+ logrus.Infof("waiting for tcpRoute %q to connect with rollout %q (expecting canary weight: %d)", resourcesMap[TCP_ROUTE_KEY].GetName(), resourcesMap[ROLLOUT_KEY].GetName(), FIRST_CANARY_ROUTE_WEIGHT)`
`110`	`111`	`err = wait.For(`
`111`	`112`	`waitCondition.ResourceMatch(`
`112`	`113`	`resourcesMap[TCP_ROUTE_KEY],`
`@@ -180,6 +181,7 @@ func testSingleTCPRoute(ctx context.Context, t testing.T, config envconf.Confi`
`180`	`181`	`}`
`181`	`182`	`logrus.Infof("rollout %q was updated", resourcesMap[ROLLOUT_KEY].GetName())`
`182`	`183`	`waitCondition := conditions.New(clusterResources)`
	`184`	`+ logrus.Infof("waiting for tcpRoute %q to update canary weight to %d after rollout image change", resourcesMap[TCP_ROUTE_KEY].GetName(), LAST_CANARY_ROUTE_WEIGHT)`
`183`	`185`	`err = wait.For(`
`184`	`186`	`waitCondition.ResourceMatch(`
`185`	`187`	`resourcesMap[TCP_ROUTE_KEY],`
`@@ -232,14 +234,14 @@ func getMatchTCPRouteFetcher(t *testing.T, targetWeight int32) func(k8s.Object)`
`232`	`234`	`t.Error()`
`233`	`235`	`return false`
`234`	`236`	`}`
`235`		`- logrus.Info("k8s object was type asserted")`
	`237`	`+ // logrus.Info("k8s object was type asserted")`
`236`	`238`	`err := runtime.DefaultUnstructuredConverter.FromUnstructured(unstructuredTCPRoute.Object, &tcpRoute)`
`237`	`239`	`if err != nil {`
`238`	`240`	`logrus.Errorf("conversation from unstructured tcpRoute %q to the typed tcpRoute was failed", unstructuredTCPRoute.GetName())`
`239`	`241`	`t.Error()`
`240`	`242`	`return false`
`241`	`243`	`}`
`242`		`- logrus.Infof("unstructured tcpRoute %q was converted to the typed tcpRoute", tcpRoute.GetName())`
	`244`	`+ // logrus.Infof("unstructured tcpRoute %q was converted to the typed tcpRoute", tcpRoute.GetName())`
`243`	`245`	`return *tcpRoute.Spec.Rules[ROLLOUT_ROUTE_RULE_INDEX].BackendRefs[CANARY_BACKEND_REF_INDEX].Weight == targetWeight`
`244`	`246`	`}`
`245`	`247`	`}`